feat(DTFS2-7052): moving address examples to constants

UK-Export-Finance · Apr 25, 2024 · de7a0e5 · de7a0e5
1 parent 6bf5a4d
commit de7a0e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/constants/geospatial.constant.ts b/src/constants/geospatial.constant.ts
@@ -5,6 +5,9 @@ export const GEOSPATIAL = {
   },
   EXAMPLES: {
     POSTCODE: 'SW1A 2AQ',
+    ORGANISATION_NAME: 'CHURCHILL MUSEUM & CABINET WAR ROOMS',
+    ADDRESS_LINE_1: 'CLIVE STEPS KING CHARLES STREET',
+    LOCALITY: 'LONDON',
   },
   REGEX: {
     // UK postcode regex is from DTFS project and slightly optimised by lint.

diff --git a/src/modules/geospatial/dto/get-addresses-response.dto.ts b/src/modules/geospatial/dto/get-addresses-response.dto.ts
@@ -6,13 +6,13 @@ export type GetAddressesResponse = GetAddressesResponseItem[];
 export class GetAddressesResponseItem {
   @ApiProperty({
     description: 'Organisation name if available',
-    example: 'CHURCHILL MUSEUM & CABINET WAR ROOMS',
+    example: GEOSPATIAL.EXAMPLES.ORGANISATION_NAME,
   })
   readonly organisationName: string | null;
 
   @ApiProperty({
     description: 'Address line 1',
-    example: 'CLIVE STEPS  KING CHARLES STREET',
+    example: GEOSPATIAL.EXAMPLES.ADDRESS_LINE_1,
   })
   readonly addressLine1: string;
 
@@ -30,7 +30,7 @@ export class GetAddressesResponseItem {
 
   @ApiProperty({
     description: 'Locality, Town',
-    example: 'LONDON',
+    example: GEOSPATIAL.EXAMPLES.LOCALITY,
   })
   readonly locality: string | null;