Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the finally block on applicable try/catch statements. #2078

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

klortiz13
Copy link
Contributor

@klortiz13 klortiz13 commented Sep 29, 2024

Summary

This pull requests aims to make the code more readable by refactoring the present try/catch statements so that they now use the finally block.

Changelog

[General] [Add] - Added the finally block to applicable try/catch statements for better readability and debugging.

Test Plan

@klortiz13 klortiz13 self-assigned this Sep 29, 2024
@klortiz13 klortiz13 requested review from morebytes and removed request for morebytes October 1, 2024 22:02
Copy link
Contributor

@morebytes morebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You need to merge with latest upstream changes before we can PR

@klortiz13
Copy link
Contributor Author

@morebytes Fixed merging conflicts, ready for testing.

Copy link
Contributor

@morebytes morebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully tested. Looks all good, approved

@morebytes morebytes merged commit a75e591 into experimental Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On Experimental Branch
Development

Successfully merging this pull request may close these issues.

3 participants