Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to the parking widget #2044

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fixes to the parking widget #2044

merged 3 commits into from
Sep 27, 2024

Conversation

MaximPodgore
Copy link
Contributor

Summary

  • For Osler and Scholars, they'd cause NaN errors when testing these newly integrated lots and crash the parking widget.
  • I fixed the NaN errors and made "SR" spots show up as "SR"

Resolves #1945

Changelog

[General] [FIX] - Fixed NaN errors in the parking widget
[General][Change] - SR spots show up as SR in the app, now in accordance with UCSD

Test Plan

Tested it locally using an emulator.

For reference, here's the pictures of the lots working on my emulator:
scholars
osler

morebytes
morebytes approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@morebytes morebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, latest test results came back 100% working

@morebytes morebytes merged commit 935d699 into UCSD:experimental Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morebytes morebytes morebytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Campus Mobile
Status: On Experimental Branch
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parking Data Update
3 participants
@MaximPodgore @morebytes @c3bryant