Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Busyness redesign #2041

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Busyness redesign #2041

merged 7 commits into from
Sep 25, 2024

Conversation

tkiyohar
Copy link
Contributor

Summary

This Pull Request implements the outlined redesign discussed in the following one-pager: https://ucsdcollab.atlassian.net/wiki/external/MTEwNDg3NTc4NDU5NDg3MDgzMjFjMTZiZDJjMTViMmY

Changelog

[General] [Change] - redesigns business card for improved user experience

Test Plan

Look for bugs in the following:

  • Ensure individual busyness card pages are no longer vertically scrollable and now comfortably fit 3 locations per page
  • Ensure busyness pages split across multiple pages (e.g., Dining Halls (1/2) and Dining Halls (2/2)) appear and are next to each other regardless of reordering (e.g., if you see a page EXAMPLE (1/3), that card should be immediately followed by pages of the form EXAMPLE (2/3) and EXAMPLE (3/3)).
  • Try enabling, disabling, and reorganizaing locations via the "manage locations" button
  • Perform any misc testing with the busyness card you can think of (e.g., view busyness card when logged in or logged out, try reordering and hiding busyness card, etc.)

@tkiyohar tkiyohar requested a review from c3bryant July 11, 2024 18:04
Copy link
Contributor

@morebytes morebytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was tested

@morebytes morebytes removed the request for review from c3bryant September 25, 2024 23:50
@morebytes morebytes merged commit 339a663 into UCSD:experimental Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On Experimental Branch
Development

Successfully merging this pull request may close these issues.

3 participants