Add scroll position saving #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
c3bryant
reviewed
Mar 5, 2024
| @@ -16,6 +17,8 @@ import 'package:pointycastle/asymmetric/api.dart'; | |||
| import 'package:pointycastle/asymmetric/oaep.dart'; | |||
| import 'package:pointycastle/pointycastle.dart' as pc; | |||
|
|
|||
| import '../../ui/home/home.dart'; | |||
There was a problem hiding this comment.
TODO (later): Refactor scroll controller reset methods to campus mobile core
c3bryant
reviewed
Mar 5, 2024
lib/core/providers/cards.dart
Outdated
| @@ -335,6 +336,10 @@ class CardsDataProvider extends ChangeNotifier { | |||
| } | |||
|
|
|||
| void toggleCard(String card) { | |||
| debugPrint("THIS IS THE CURRENT CARD BEING TOGGLED: " + card); | |||
| if ((card == "student_health_wellbeing" || card == "student_info" || card == "campus_info") && _cardStates![card]!) { | |||
There was a problem hiding this comment.
Explore dynamically applying resetCardHeight
c3bryant
previously requested changes
Mar 5, 2024
tkiyohar
force-pushed
the
addScrollPositionSaving
branch
from
3b919bb
to
8c63350
Compare
added 4 commits
September 2, 2024 11:06
…reload properly if they freeze)
morebytes
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-- Reimplementation of previous PR that was wrongly repealed: "Add scroll position saving #1935" --
-- Additionally includes some code changes and improvements to the original scroll position saving code --
Adds scroll position saving to the Home and Notifications app screens, fixes resizing error with home screen web cards (needed for scroll position saving), and adds loading screens to home screen web cards (prevents content flickering + looks much nice with scroll position saving).
Changelog
[General] [Add] - Adds scroll position saving to home and notifications pages (also includes code from Gradle update PR: "Update Gradle Version and Settings #2017")
Test Plan
Test the home page and notifications page for any bugs and to see if their scroll position is maintained when switching between screens using the bottom nav bar after messing around on either screen (e.g., hiding or unhiding cards on the home screen from either the home screen itself or the profile screen, toggling "I'm going" on certain free food events, etc).
Also test logging in and out of student, guest and employee accounts to make sure the scroll position on both the home and notifications pages are reset when logging in/out of an account.
If this PR is successful, the scroll position should be seamlessly saved on the notifications and home screens without any jumpy behavior when reloading these screens. Additionally, web cards (e.g., "Campus Information" and "Health & Well-being" cards) should now display a loading screen while their contents are loading in. No other behavior of the app should be affected.