Campus Events Notification Pilot #1954 #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents" This reverts commit 3b47a61.
c3bryant
reviewed
Oct 17, 2023
| @@ -33,7 +33,7 @@ class FreeFoodDataProvider extends ChangeNotifier { | |||
| String? _error; | |||
|
|
|||
| ///MODELS | |||
| FreeFoodModel? _freeFoodModel; | |||
| IAmGoingModel? _freeFoodModel; | |||
| late MessagesDataProvider _messageDataProvider; | |||
|
|
|||
| ///SERVICES | |||
There was a problem hiding this comment.
@tkiyohar @Jackkkkkkdzk parseMessages requires an update:
if (m!.audience != null &&
m.audience!.topics != null &&
(m.audience!.topics!.contains("freeFood") || m.audience!.topics!.contains("campusInnovationEvents"))
)
Fixed innovations event refetching errors
c3bryant
changed the title
c3bryant
approved these changes
Dec 5, 2023
14 tasks
|
This PR failed UAT after merge and was never deployed. Reverting and sending to the backlog for re-evaluation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applying FreeFood Notification format (I'm Going checkbox, number of students going) to Innovation Events notification.
Changelog
[General] [Add] - Add a function needIAmGoingFeature in notifications_list_view to decide whether input event should use I'm Going feature
[General] [Change] - Refactor file name and class name in ui/notifications from freeFoodNotification to iAmGoingNotification
Test Plan
Open the App, navigate to notification page
Check whether the I'm Going checkbox is applied to both Innovation Events and FreeFood