Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast feature #1932

Merged
merged 56 commits into from
Aug 25, 2023
Merged

Podcast feature #1932

merged 56 commits into from
Aug 25, 2023

Conversation

mliu6723
Copy link
Contributor

@mliu6723 mliu6723 commented Mar 2, 2023

Summary

  • Complete KSDT Radio feature
  • Implement triton_media with just audio
  • Implement background audio (can control audio from background/lock screen)

Changelog

[General] [Add] - Add KSDT radio feature
[General][Add] - Added support for background audio
[General][Change] - Fixed dark mode bug for text
[General][Add] - Added volume and speed setting buttons that can be used in the future
[General][Add] - Added forward/reverse buttons for if playlist will be implemented in the future
[General][Change] - Update play button for radio so it plays at the live state of the radio when pressed
[iOS][Add] - Added to Runner/info.plist to allow permissions for background audio
[Android][Add] - Added dependencies for just audio and dependencies for background audio

Test Plan

  • Tested on physical iOS device (iPhone 14)
  • Tested on live radio broadcasts
  • Tested on android emulator

Vijay and others added 30 commits November 12, 2022 16:12
…s integrating the package into the speed_test.dart provider
…s integrating the package into the speed_test.dart provider
Readme.md Outdated
@@ -12,7 +12,7 @@ We look forward to helping you become a published app developer!
## How to Contribute

### Install Flutter
Campus Mobile supports [Flutter 3.7.x](https://docs.flutter.dev/development/tools/sdk/upgrading#switching-flutter-channels)
Campus Mobile supports [Flutter's stable channel](https://docs.flutter.dev/development/tools/sdk/upgrading#switching-flutter-channels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change

@@ -15,7 +16,7 @@
android:icon="@mipmap/ic_launcher"
android:roundIcon="@mipmap/ic_launcher_round">
<activity
android:name=".MainActivity"
android:name="com.ryanheise.audioservice.AudioServiceActivity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change

@@ -445,7 +457,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 16.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change unless it is required

@@ -537,7 +549,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 16.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change unless it is required

@@ -586,7 +598,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 16.1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change unless it is required

pubspec.yaml Outdated
@@ -36,7 +37,7 @@ dependencies:
ref: 9fd5cc0aa1a68d70588741f40bfc6830b46c10c1
geolocator: ^9.0.2
package_info: 2.0.2
percent_indicator: 4.2.2
percent_indicator: 3.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

pubspec.yaml Outdated
@@ -58,5 +64,6 @@ dependency_overrides:
flutter:
uses-material-design: true
assets:
- assets/theme_01.mp3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

pubspec.yaml Outdated
@@ -48,6 +49,11 @@ dependencies:
git:
url: https://github.com/UCSD/wifi_connection.git
ref: 179eb3a322b9d947752b4ff4e810582c3e262e47
cancellation_token_http: ^1.1.0
audioplayers: ^1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

pubspec.yaml Outdated
@@ -48,6 +49,11 @@ dependencies:
git:
url: https://github.com/UCSD/wifi_connection.git
ref: 179eb3a322b9d947752b4ff4e810582c3e262e47
cancellation_token_http: ^1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change

@c3bryant c3bryant merged commit c966e1b into UCSD:experimental Aug 25, 2023
2 checks passed
c3bryant added a commit to c3bryant/campus-mobile that referenced this pull request Oct 18, 2024
This reverts commit c966e1b, reversing
changes made to fff5465.
morebytes added a commit that referenced this pull request Oct 22, 2024
Revert "Merge pull request #1932 from mliu6723/podcast_feature"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants