Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work-around LLVM clang bug (?) #920

Closed
wants to merge 2 commits into from
Closed

work-around LLVM clang bug (?) #920

wants to merge 2 commits into from

Conversation

KrisThielemans
Copy link
Collaborator

We get linking errors on MacOSX with LLVM clang related to TrivialBinNormalisation's vtable. This is probably because it has
only inline functions, so now we have a non-inline one.

Fixes #910

@KrisThielemans
work-around LLVM clang bug (?)
9cf981a 
We get linking errors on MacOSX with LLVM clang related to
TrivialBinNormalisation's vtable. This is probably because it has
only inline functions, so now we have a non-inline one.

Fixes UCL#910
@KrisThielemans
Copy link
Collaborator Author

Previous commit changed the error to https://app.travis-ci.com/github/UCL/STIR/jobs/533049342#L8628

Undefined symbols for architecture x86_64:
  "stir::BinNormalisation::BinNormalisation()", referenced from:
      stir::LmToProjData::set_defaults() in liblistmode_buildblock.a(LmToProjData.cxx.o)
  "vtable for stir::TrivialBinNormalisation", referenced from:
      stir::LmToProjData::set_defaults() in liblistmode_buildblock.a(LmToProjData.cxx.o)
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.

@KrisThielemans
add explicit TrivialBinNormalisation default constructor
e80d19b 
hopefully works around LLVM 12.0.1 bug
@KrisThielemans
Copy link
Collaborator Author

Adding an explicit default constructor didn't help.

@KrisThielemans
Copy link
Collaborator Author

This seems to have been a clang bug, so closing this PR

@KrisThielemans KrisThielemans deleted the fix_TrivialBinNorm branch May 6, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Travis osx, OpenMP using llvm clang 12.0.1 gives linking errors
1 participant
@KrisThielemans