-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Hessian test to PoissonLogLikelihoodWithLinearModelForMeanAndProjData (and fix Hessian) #902
Conversation
I cannot workout why this was closed, it is a fix to the |
…sian_concavity This is a change to keep consistency with changes in UCL#901
For Poisson methods: Uses of
Uses of
Of the |
…lip sign on each voxel
…as negative values
src/recon_test/test_PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx
Outdated
Show resolved
Hide resolved
src/recon_test/test_PoissonLogLikelihoodWithLinearModelForMeanAndProjData.cxx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kris Thielemans <[email protected]>
Co-authored-by: Kris Thielemans <[email protected]>
Addresses #911
Adds
test_objective_function_Hessian
which utilisesobjective_function.accumulate_Hessian_times_input
to test the concavity conditionx^T H x <= 0
.Modifies
actual_accumulate_sub_Hessian_times_input_without_penalty
(and approximate version) inPoissonLogLikelihoodWithLinearModelForMeanAndProjData
to be a concave functions (plus -> minus)