Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for origin shift 2020 #618

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Prepare for origin shift 2020 #618

wants to merge 31 commits into from

Commits on Jan 5, 2021

  1. Places that changes need to occur to account for bed position

    @ashgillman
    Richard Brown authored and ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    462d168 View commit details
    Browse the repository at this point in the history

  2. [REF] Use m_in_mm instead of t_in_mm in ProjMatrixByBinUsingRayTracing

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3032a21 View commit details
    Browse the repository at this point in the history

  3. [REF] Simplify calculation and correction of phi and s_in_mm In ProjM… 

    …atrixByBinUsingRayTracing
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3ea49da View commit details
    Browse the repository at this point in the history

  4. [REF] Remove unneeded argument to ray_trace_one_lor()

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d4f0d14 View commit details
    Browse the repository at this point in the history

  5. [REF] Use DiscretisedDensity's index <-> physical space conversions i… 

    …n ProjMatrixByBinUsingRayTracing
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    22d98e7 View commit details
    Browse the repository at this point in the history

  6. [REF] Address comments https://github.com/UCL/STIR/pull/260/files/036… 

    …5f964a565fa488b278e6a5eb20fa337572b11
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f8034f0 View commit details
    Browse the repository at this point in the history

  7. FIX: Do better with test_DataSymmetries... 

    Now passes until non-standard range of planes.
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    dace9a2 View commit details
    Browse the repository at this point in the history

  8. ENH: DSFB_PET_CG to use PDI for physical<->gantry coords

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    06f2675 View commit details
    Browse the repository at this point in the history

  9. ENH: DSFB_PET_CG to use axial pos 0 always for offset calc.

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    6dbd3aa View commit details
    Browse the repository at this point in the history

  10. TST: Don't use symmetries when synthesising sinograms in recon tests

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    67fed57 View commit details
    Browse the repository at this point in the history

  11. ENH: FBP3DRPR don't auto centre image in scanner.

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    27a7257 View commit details
    Browse the repository at this point in the history

  12. ENH: Add DD get_image_centre..., move some VOCG functionality up hier… 

    …archy
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    42aa142 View commit details
    Browse the repository at this point in the history

  13. TST: Start of tests for coordinate system mapping. 

    Currently just tests RT matrix fwd and back consistency.
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    473a9f4 View commit details
    Browse the repository at this point in the history

  14. REF: Neaten up tests a bit before adding FOV tests

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    40447f8 View commit details
    Browse the repository at this point in the history

  15. TST: Add tests comparing projectors - currently failing but correctly… 

    … so.
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    e073170 View commit details
    Browse the repository at this point in the history

  16. TST: FOV tests comparing projectors working, only RT and Interp Matri… 

    …x included
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ede7d51 View commit details
    Browse the repository at this point in the history

  17. ENH: PMBBUI uses PDI for gantry-space conversions, supports non-axial… 

    …ly-centred images.
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    c3442a0 View commit details
    Browse the repository at this point in the history

  18. FIX: Forgot to push RunTests's VectorWithOffset iterator check

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3f290eb View commit details
    Browse the repository at this point in the history

  19. REF: Decouple PMBBURT a little more from DD members

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0515d89 View commit details
    Browse the repository at this point in the history

  20. FIX: Failures in some tests.

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    35b5340 View commit details
    Browse the repository at this point in the history

  21. REF: Updated PDICNAC functions 

    using a different convention called cartesian coordinates, and changed to gantry coordinates
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d1ded0e View commit details
    Browse the repository at this point in the history

  22. REF: Fix some variables that are actually in gantry_coords

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d887601 View commit details
    Browse the repository at this point in the history

  23. DOC: Some potential new TODOs

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    df48818 View commit details
    Browse the repository at this point in the history

  24. REF: Remove some unnecessary TODO items

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f3ee74b View commit details
    Browse the repository at this point in the history

  25. ENH: Densels Symmetries - use coordinate system transform funtions

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    7a4d8ec View commit details
    Browse the repository at this point in the history

  26. FIX: Scatter Integrals - no need to shift origin

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d58124c View commit details
    Browse the repository at this point in the history

  27. REF: Use image function for centre

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5d38ee2 View commit details
    Browse the repository at this point in the history

  28. FIX: Logic error with gantry offset. gantry.z + ring_to_centre = ring… 

    …_coord
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a2fc8e7 View commit details
    Browse the repository at this point in the history

  29. REF: Make Scatter coord systems more explicit

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    a48638c View commit details
    Browse the repository at this point in the history

  30. FIX: Small scatter issues

    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    86d9049 View commit details
    Browse the repository at this point in the history

  31. FIX: Old bug in downample_scanner doesn't preserve scanner length cor… 

    …rectly
    @ashgillman
    ashgillman committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    886c95f View commit details
    Browse the repository at this point in the history