Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter forward projector setter #1530

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

robbietuk
Copy link
Collaborator

@robbietuk robbietuk commented Oct 28, 2024

Changes in this pull request

Introduces the ability to set and retrieve a forward projector for scatter estimation, used in mask forward projection, in the ScatterEstimation class. Also adds a keymap parser.

Related issues

Fixes #1527

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • documentation/release_XXX.md has been updated with any functionality change (if applicable)

@KrisThielemans KrisThielemans added this to the v6.3 milestone Oct 30, 2024
@robbietuk
Copy link
Collaborator Author

Ready to merge.

src/include/stir/scatter/ScatterEstimation.h Outdated Show resolved Hide resolved
src/include/stir/scatter/ScatterEstimation.h Outdated Show resolved Hide resolved
src/include/stir/scatter/ScatterEstimation.h Outdated Show resolved Hide resolved
src/scatter_buildblock/ScatterEstimation.cxx Outdated Show resolved Hide resolved
@KrisThielemans
Copy link
Collaborator

ah, sorry, can you add a line to release_6.3.htm please? (include [ci skip] in the commit, as it seems our "exclude *htm doesn't work for GitHub Actions)

@KrisThielemans
Copy link
Collaborator

I'll squash-merge if ok

@KrisThielemans KrisThielemans self-assigned this Nov 27, 2024
@KrisThielemans
Copy link
Collaborator

looks like there's a conflict with master in the release notes...

@KrisThielemans KrisThielemans merged commit a008e73 into UCL:master Nov 27, 2024
1 of 9 checks passed
@robbietuk robbietuk deleted the scatter_forward_projector_setter branch November 28, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EstimateScatter forces the use of ForwardProjectorByBinUsingProjMatrixByBin for mask computation
2 participants