Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLEstimateComponentBasedNormalisation refactor #1499

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

MLEstimateComponentBasedNormalisation refactor #1499

wants to merge 35 commits into from
+971 −362

Commits on Aug 29, 2024

  1. Refactor ML_estimate_component_based_normalisation creating sub-funct… 

    …ions
    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    3035db8 View commit details
    Browse the repository at this point in the history

  2. Create MLEstimateComponentBasedNormalisation class and start to strip… 

    … method arguments
    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    bc58f39 View commit details
    Browse the repository at this point in the history

  3. Refactor to use class varables

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0dca08e View commit details
    Browse the repository at this point in the history

  4. Add do_save_to_file guards

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    9fed40f View commit details
    Browse the repository at this point in the history

  5. Documentation and minor refactors

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2579f81 View commit details
    Browse the repository at this point in the history

  6. Rename refactor

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5d89071 View commit details
    Browse the repository at this point in the history

  7. Addition usage of shared_ptrs

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    86f6a82 View commit details
    Browse the repository at this point in the history

  8. [ci skip] parameter rename, remove redundant logic, documentation

    @robbietuk
    robbietuk committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    880e530 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Remove model_data member and pass by reference into the constructor

    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dd711b1 View commit details
    Browse the repository at this point in the history

  2. Readd stir/steam.h to includes

    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    2bcdc80 View commit details
    Browse the repository at this point in the history

  3. [ci skip] Update copywrite

    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0fa8455 View commit details
    Browse the repository at this point in the history

  4. [ci skip] Fix a bug with do_KL info print

    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    90ea81b View commit details
    Browse the repository at this point in the history

  5. Add allocate override using a MLEstimateComponentBasedNormalisation 

    Adds has_processed_data to MLEstimateComponentBasedNormalisation
    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f0c788b View commit details
    Browse the repository at this point in the history

  6. [ci skip] cleanup comments

    @robbietuk
    robbietuk committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e5e2cc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Rename files MLEstimateComponentBasedNormalisation

    @robbietuk
    robbietuk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8adb620 View commit details
    Browse the repository at this point in the history

  2. Remove allocate with norm estimator

    @robbietuk
    robbietuk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9ff77fe View commit details
    Browse the repository at this point in the history

  3. Add construct_bin_normfactors_from_components to MLEstimateComponentB… 

    …asedNormalisation
    @robbietuk
    robbietuk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5c1a0f7 View commit details
    Browse the repository at this point in the history

  4. Change efficiencies, norm_block_data, norm_geo_data values from sptr

    @robbietuk
    robbietuk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a114d14 View commit details
    Browse the repository at this point in the history

  5. Documentation update.

    @robbietuk
    robbietuk committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b0e05c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Fix variable names

    @robbietuk
    robbietuk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1d6ca9b View commit details
    Browse the repository at this point in the history

  2. Add guard to ensure measured and model data use the same pdi

    @robbietuk
    robbietuk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0aae32e View commit details
    Browse the repository at this point in the history

  3. Add test for MLEstimateComponentBasedNormalisation

    @robbietuk
    robbietuk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ca1140c View commit details
    Browse the repository at this point in the history

  4. Correct comparison to objects, not sptr

    @robbietuk
    robbietuk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2935b99 View commit details
    Browse the repository at this point in the history

  5. [ci skip] Fix min/max tolerance check

    @robbietuk
    robbietuk committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3c11502 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Change scanner to Discovery 

    This allows the test to pass and ignores the to ignore even num_tangential_poss issue
    @robbietuk
    robbietuk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7c18bc7 View commit details
    Browse the repository at this point in the history

  2. Add additional test on efficiency values

    @robbietuk
    robbietuk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    42340f2 View commit details
    Browse the repository at this point in the history

  3. Ensure normalization_projdata max and min values are about 2.0

    @robbietuk
    robbietuk committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f424ca8 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Make test use check_if_equal

    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a5f4b91 View commit details
    Browse the repository at this point in the history

  2. Split test_normalization_calculation_with_efficiencies from the run_t… 

    …ests function

Also documentation
    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1eefeff View commit details
    Browse the repository at this point in the history

  3. Improve usage of data_is_processed()

    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dcee251 View commit details
    Browse the repository at this point in the history

  4. Add getters and setters

    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    63f8560 View commit details
    Browse the repository at this point in the history

  5. [ci skip] Add const to args

    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3d7e9ff View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'UCL/master' into ML_estimate_component_… 

    …based_normalisation_redesign
    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    55e5f1a View commit details
    Browse the repository at this point in the history

  7. [ci skip] Update release 6.3 notes

    @robbietuk
    robbietuk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    55897ee View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. [ci skip] Fix error message

    @robbietuk
    robbietuk committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cbe81ec View commit details
    Browse the repository at this point in the history