SRT2D repository: SRT 2D PET and SPECT algorithms #1420
Conversation
Changes to use initial SSRB and arc-correction
…rom file - symmetry used" This reverts commit b32bb29.
Corrected the 2 mistakes in the Codacy report
Correction of the 8 (potentially minor) mistakes of the Codacy report
…hs [ci skip] typo in file name
…e_PET_data_for_tests.sh [ci skip] Applied Codacy static requested changes Also changed the file's name to the original, because it created a conflict which prevented Appveyor from running
Applied changed requested from Codacy static
|
Dear Professor @KrisThielemans, THANK YOU WHOLEHEARTEDLY! |
Checking if this change can lead to running Build and ctest and recon_test_pack CI
Checking if this change will run the Build and ctest and recon_test_pack CI tests
Reverting the last change to the original file, as the change did not lead to the running of Build and ctest and recon_test_pack CI tests
There is no chage in the file. As only Codacy and not CI test runs after changes in build-test.yml, I had to make a space change here for Appveyor to run for my pull-request after my last build-test.yml change
|
Dear Professor @KrisThielemans, THANK YOU WHOLEHEARTEDLY!!! |
I had forgoten the last line: 'fi'
|
Dear Professor @KrisThielemans, Also I have the impression that maybe this file could be renamed to 'simulate_PET_and_SPECT_data_for_tests.sh'; I could not rename it because this led to a problem in merging. THANK YOU WHOLEHEARTEDLY FOR ALL YOUR INVALUABLE HELP!!! |
I changed a whitespace, so that Appveyor would run
|
Dear Professor @KrisThielemans, THANK YOU WHOLEHEARTEDLY FOR ALL YOUR INVALUABLE HELP!!! |
corrected name of file, so that it does not include the term 'SPECT' twice
|
Dear Professor, Locally on my pc the tests run; I attach the screenshots. Also the reconstructed image is ok. I) The Build CI error is that forward_project fails. Could you maybe access the my_create_sino_SPECT.log file that was created, in case it has extra info than my .log file? II) Locally on my pc my_create_sino_SPECT.log, which I attach contains 5 warnings, which I can't imagine causing this fail.
III) For run_test_simulate_and_reckon.sh to run the emission and attenuation data cannot be altered; only _the SPECT scanner parameters can be altered, and of course the forward_project.par file. I am really sorry for all the trouble. I am looking forward to your reply. THANK YOU WHOLEHEARTEDLY FOR YOUR PATIENCE, AND ALL YOUR TRULY INVALUABLE HELP!!! |
|
Dear Professor @KrisThielemans , Locally in my reckon_test_pack I had both SPECT_test_Interfile_header.hs and SPECT_Interfile_header.hs (because I wanted to have a backup in case of changes), hence I apparently copied the content of the 2nd, while having given the name of the 1st... I now corrected the mistake, and Appveyor and Codacy run again. I am really sorry. I hope this is the last mistake... THANK YOU WHOLEHEARTEDLY FOR YOUR PATIENCE, AND FOR ALL YOUR INVALUABLE HELP!!! |
|
Dear Professor @KrisThielemans , I need to change a typo I noticed in the error message for SPECT sinogram. I wonder whether the file simulate_PET_data_for_tests.sh might be changed to THANK YOU WHOLEHEARTEDLY FOR YOUR PATIENCE, AND ALL YOUR INVALUABLE HELP!!! |
|
Dear Professor @KrisThielemans , THANK YOU WHOLEHEARTEDLY FOR YOUR PATIENCE, AND ALL YOUR INVALUABLE HELP!!! |
correction of typo in error message
removed terminal message
|
Dear Professor @KrisThielemans , THANK YOU WHOLEHEARTEDLY FOR YOUR PATIENCE, AND ALL YOUR INVALUABLE HELP!!! |
|
Thanks @Dimitra-Kyriakopoulou, success! I will provide a review later, but probably only second half of August due to commitments. In any case, we know this is good to go now! |
|
Dear Professor @KrisThielemans , |
Changes in this pull request
2 new analytic reconstruction algorithms SRT 2D PET in the src→ analytic → SRT2D folder and SRT 2D SPECT in the src→ analytic → SRT2DSPECT folder of my SRT2D repository.
[In 2016 in SRT2D folder had been uploaded the prior versions of both these two codes: these old versions do not work with the current STIR version (as there had been pointer etc changes in STIR in between). Also the new versions of the 2 algorithms are improved, e.g. the old SRT2DSPECT run only for uniform data, whereas the new one doesn’t have such restriction.]
Testing performed
Related issues
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)