Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TightBad to the event information. #1677

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

russbate42
Copy link
Contributor

No description provided.

@mdhank
Copy link
Contributor

mdhank commented Feb 19, 2024

Hi @russbate42 ,

Is this implementing the changes in this athena MR? If so, we should wait until that is finalized to merge this PR.

I also wanted to check if there are any corresponding changes that should be made to our cleaning cuts. Currently, we apply the "DFCommonJets_eventClean_LooseBad" cut if the jet cleaning flag is set, see BasicEventSelection.cxx#L919. Is this still the recommended default? Should the code be changed to allow a choice between no jet cleaning, loose, and tight?

Best,
Michael

@mswiatlo
Copy link
Contributor

mswiatlo commented Feb 20, 2024

Hi @mdhank -- I'll let Russell answer the detailed questions but yes, this is meant to implement that MR in atlas/Athena, so it should go first!

@mdhank
Copy link
Contributor

mdhank commented Mar 22, 2024

Hi @russbate42 ,

I wanted to follow-up on this- it looked like the corresponding Athena MR was merged. I think the only outstanding point is if we should change how we apply the jet cleaning.

Best,
Michael

@tofitsch
Copy link
Contributor

tofitsch commented Apr 2, 2024

Hi @mdhank , @russbate42 , LooseBad should stay the default for cleaning also in Run 3 (confirmed by Fabrice). The MR should be complete then. Can be merged.

@tofitsch tofitsch merged commit a87d6f6 into UCATLAS:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants