-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xAH updates for Trigger-Level Analyses #1676
Conversation
…igger decision checks on 2022/2023 TLA data
…e688cf057bebbfe) and carry over support for TProfile filling from 13e972336dee475ec9a114bc44b4b01c96b687d4 / 7735da175836f8ee6653fea1bf793426a0cad9d5
…of ConstDataVector for jets and photons
To add some context: These changes are needed in the dijet+ISR Trigger Level Analysis (TLA) which makes heavy use of xAH. They will also be necessary for other later trigger level analyses. JetCalibratorLooks fine: While these new features are only needed for TLA, they are activated by the new option BasicEventSelectionSimilarly, everything new is guarded behind the new
to something like this:
It's probably better to change HistogramManagerAlso fine: Just adding a few more overloaded options of functions that exist for TH2 now for TH3 OverlapRemoverLooks a bit strange only doing it for jets and photons. Should we not do the same (i.e. adding the conditional without |
Updates:
|
df8397b
to
153c6c8
Compare
… consistent for all object types
Adds various modifications including:
JetCalibrator
for correcting HLT jets (new options for setting upJetCalibrationTool
, yet to be upstreamed in Athena but planned)TProfile
&TH3
objects withHistogramManager
OverlapRemover
, only for checking existence in TStore when deep/shallow copies existBasicEventSelection
adding a TLA data flag to control how trigger decisions are checked (from some differences between trigger decisions stored in 2022 TLA data & the primary physics data stream)NOTE: for
BasicEventSelection
trigger decision changes we may need a follow up PR after checking if the modified TLA data logic is required for 2023 TLA data (if not, then we will need a 2022 TLA data flag)