Feedback andres

[AndresPitta]

Hi guys,

This commit contains the following changes:

• The README.md file was modified to contain information about the dependecies and how to install the correct version of them. This addresses @kvarada's following feedback on issue #31:

here

Installation directions might benefit from some clarification. I had to do the following in order to get it working.

conda install selenium
pip install python-semantic-release

here

Good that you include the instruction to put the chromedriver path in the system path variable. I guess you do not mean PATH_TO_CHROMEDRIVER.EXE in the following command for Linux and MacOS.

export PATH="<PATH_TO_CHROMEDRIVER.EXE>:$PATH"

and here

Tests
When I ran your tests, two tests failed with the following error.
AttributeError: module 'altair.vegalite' has no attribute 'v4'

• The README.md file was also modified to have the correct example for the function nba_ranking, in order to address @kvarada and @zoepan00 feedback on issue #31:

here:

Step 3 example nba_ranking(nba_2018_regular, 'PLAYER' , 'GP', top = 2, ascending = False, fun = 'mean') is not working

and here:

In your README, in the following usage example of the function nba_ranking, the 'PLAYER' column is undefined in the scraped CSV and so it gives an error. Replacing it with 'NAME' worked for me.
nba_ranking(nba_2018_regular, 'PLAYER' , 'GP', top = 2, ascending = False, fun = 'mean')

• nba_ranking's error message was updated to address @zoepan00's feedback on issue #31:

nba_ranking: Error message for fun argument is not updated. Currently it says The fun argument should be either var or mean

Please check everythin is in order,
Thanks,
Andres

[codecov]

Codecov Report

Merging #60 into master will not change coverage by %.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          295       295           
=========================================
  Hits           295       295           

Flag	Coverage Δ
#unittests	100.00% <100.00%> (ø)

Impacted Files	Coverage Δ
pysketball/nba_ranking.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6e568...845954c. Read the comment docs.

[vanandsh]

All changes look fine! Thanks @AndresPitta