-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review fixes #59
Review fixes #59
Conversation
vanandsh
commented
Mar 23, 2020
- Updated metadata for authors etc. information in pyproject.toml
- Updated docstring for season_type argument in nba_scraper.py
- Updated docstring to include example outputs in nba_team_stats.py
- Updated code to round the numbers for mean and std columns in nba_team_stats.py
- Rendered docs for local viewing
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 295 295
=========================================
Hits 295 295
Continue to review full report at Codecov.
|
Hey @vanandsh, I see this PR addresses the following feedback:
Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!