added sessions integration and remaining schemas #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @UBA-GCOEN on Vercel. @UBA-GCOEN first needs to authorize it. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+8
to
+16
| app.use(session({ | ||
| secret: process.env.SESSION_SECRET, | ||
| resave: false, | ||
| saveUninitialized: false | ||
| }, | ||
| (next)=>{ | ||
| next() | ||
| } | ||
| )) |
Check warning
Code scanning / CodeQL
Clear text transmission of sensitive cookie
| const router = express.Router(); | ||
|
|
||
| import {userAdmin, signup, signin} from "../controllers/userAdmin.js"; | ||
|
|
||
|
|
||
| router.get("/", userAdmin) | ||
| router.post("/signup", signup) | ||
| router.post("/signin", signin) | ||
| router.post("/signin", session, signin) |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
|
||
| import {userStudent, signup, signin} from "../controllers/userStudent.js"; | ||
|
|
||
|
|
||
| router.get("/", userStudent) | ||
| router.post("/signup", signup) | ||
| router.post("/signin", signin) | ||
| router.post("/signin",session, signin) |
Check failure
Code scanning / CodeQL
Missing rate limiting
Comment on lines
+8
to
+16
| app.use(session({ | ||
| secret: process.env.SESSION_SECRET, | ||
| resave: false, | ||
| saveUninitialized: false | ||
| }, | ||
| (next)=>{ | ||
| next() | ||
| } | ||
| )) |
Check failure
Code scanning / CodeQL
Missing CSRF middleware
Siddhant-Patil0203
added
👀 STATUS : Under Review
Backend
Signed-off-by: Naresh <[email protected]>
Siddhant-Patil0203
approved these changes
Aug 28, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there is already an active session it will log in with the session data