Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reformat.yml with the latest git-auto-commit #1043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Madoshakalaka
Copy link
Collaborator

TIL: github actions are not matched semantically (though they encourage semantic versioning of actions)

see discussion here

They match by tags/releases, that's why the git-auto-commit has tags like v4 v4.12.0 latest...etc

The readme of git auto commit seem to suggest people to use v4. Anyhow, git auto commit has released v4.12.0, yet the workflow still uses the fixed v4.3.0. Should be wrong to bump the minor version.

Also [skip ci] is unnecessary here

@codecov-commenter
Copy link

Codecov Report

Merging #1043 (b8ddc43) into main (c98e636) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   79.05%   79.00%   -0.06%     
==========================================
  Files         151      151              
  Lines        5296     5297       +1     
  Branches      685      686       +1     
==========================================
- Hits         4187     4185       -2     
- Misses        984      989       +5     
+ Partials      125      123       -2     
Impacted Files Coverage Δ
src/CreeDictionary/API/search/test_espt_crk.py 100.00% <100.00%> (ø)
src/CreeDictionary/CreeDictionary/test_views.py 94.23% <100.00%> (+0.05%) ⬆️
src/crkeng/integration_tests/test_definitions.py 96.29% <100.00%> (ø)
src/CreeDictionary/API/search/lookup.py 93.47% <0.00%> (-2.18%) ⬇️
src/CreeDictionary/API/search/espt.py 86.36% <0.00%> (-1.82%) ⬇️
src/morphodict/analysis/__init__.py 84.21% <0.00%> (-1.76%) ⬇️
src/CreeDictionary/API/search/presentation.py 81.12% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76590e7...b8ddc43. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants