-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/doc #39
Enhancement/doc #39
Conversation
This PR needs downstream testing before being merged into main. From the requests library changelog :
LD-Cool-P uses the urllib library directly as well as chunked downloads. ReBACH uses chunked downloads. Therefore, before merging this PR, the following tests are needed. With the latest requests library, test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests needed for approval. See above
After thinking about it, I think this can be merged now and the testing done at the time the update is applied to each dependent repo. LD-Cool-P and ReBACH are pinned to v0.42 and 0.41 of redata commons respectively so updating this code won't affect them right away. I'll create an issue in those repos to update this dependency and test it. |
Both shall be tested and applied. In addition, dependencies (pandas and tabulate) new versions were released. Probably these shall be upgraded at the same time. |
Description
See #36
It is a dependency upgraded to the latest version. Requests is a simple HTTP library.
Screenshots or additional context
Testing (if applicable)
All redata codes shall be performed as usual, because requests' upgrade to the latest version (2.31.0) shall have no impact to redata.