Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include inline emoji in JSON export #1311

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Include inline emoji in JSON export #1311

merged 8 commits into from
Nov 6, 2024

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Oct 26, 2024

Closes #1026

  • Adds messages[].inlineEmojis[] that contains an array of emoji objects, describing emoji used inside {message}.content.
  • Adds messages[].embeds[].inlineEmojis[] that contains an array of emoji objects, describing emoji used inside {embed}.description.
  • Both arrays are deduplicated and may be empty but never null.

@slatinsky
Copy link
Contributor

Hello,

I have tested this pull requests and I have found some small issues:

  1. messages[].embeds[].description sent by automod or by bots in a embed may contain custom emojis. Those emojis don't show up in messages[].inlineEmojis[]
  2. the same emoji sent multiple times in the same messages[].content is not deduplicated.

Other than that, the pull request looks good to me. Including the name inlineEmojis

@Tyrrrz
Copy link
Owner Author

Tyrrrz commented Nov 6, 2024

Hello,

I have tested this pull requests and I have found some small issues:

  1. messages[].embeds[].description sent by automod or by bots in a embed may contain custom emojis. Those emojis don't show up in messages[].inlineEmojis[]
  2. the same emoji sent multiple times in the same messages[].content is not deduplicated.

Other than that, the pull request looks good to me. Including the name inlineEmojis

Good points.

As for 1., do you think those emoji should be inside messages[].inlineEmojis[] or messages[].embeds[].inlineEmojis[]? The former is obviously easier, but I wonder if there's any downside.

@Tyrrrz Tyrrrz merged commit 789e5af into master Nov 6, 2024
25 checks passed
@Tyrrrz Tyrrrz deleted the json-inline-emoji branch November 6, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON option does not seem to export in-line emoji which are from other servers
2 participants