forked from xtermjs/xterm.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request xtermjs#5080 from Tyriar/tyriar/more_playwright2
Migrate remaining API tests to playwright and remove API test infrastructure
- Loading branch information
Showing
22 changed files
with
870 additions
and
842 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,47 +150,6 @@ jobs: | |
- name: Unit tests | ||
run: yarn test-unit --forbid-only | ||
|
||
test-api-parallel: | ||
timeout-minutes: 20 | ||
strategy: | ||
matrix: | ||
node-version: [18] # just one as integration tests are about testing in browser | ||
runs-on: [ubuntu] # macos is flaky | ||
browser: [chromium, firefox] | ||
runs-on: ${{ matrix.runs-on }}-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Use Node.js ${{ matrix.node-version }}.x | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }}.x | ||
cache: 'yarn' | ||
- name: Install dependencies | ||
run: | | ||
yarn --frozen-lockfile | ||
yarn install-addons | ||
- name: Install playwright | ||
run: npx playwright install | ||
- name: Wait for build job | ||
uses: NathanFirmo/[email protected] | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
job: build | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: build-artifacts | ||
- name: Unzip artifacts | ||
shell: bash | ||
run: | | ||
if [ "$RUNNER_OS" == "Windows" ]; then | ||
pwsh -Command "7z x compressed-build.zip -aoa -o${{ github.workspace }}" | ||
else | ||
unzip -o compressed-build.zip | ||
fi | ||
ls -R | ||
- name: Integration tests (${{ matrix.browser }}) | ||
run: yarn test-api-${{ matrix.browser }} --headless --forbid-only | ||
|
||
test-playwright-parallel: | ||
timeout-minutes: 20 | ||
strategy: | ||
|
@@ -238,43 +197,6 @@ jobs: | |
- name: Integration tests (addon-webgl) | ||
run: yarn test-playwright-${{ matrix.browser }} --workers=50% --forbid-only --suite=addon-webgl | ||
|
||
test-api: | ||
needs: build | ||
timeout-minutes: 20 | ||
strategy: | ||
matrix: | ||
node-version: [18] # just one as integration tests are about testing in browser | ||
runs-on: [windows] # macos is flaky | ||
browser: [chromium, firefox] | ||
runs-on: ${{ matrix.runs-on }}-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Use Node.js ${{ matrix.node-version }}.x | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }}.x | ||
cache: 'yarn' | ||
- name: Install dependencies | ||
run: | | ||
yarn --frozen-lockfile | ||
yarn install-addons | ||
- name: Install playwright | ||
run: npx playwright install | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: build-artifacts | ||
- name: Unzip artifacts | ||
shell: bash | ||
run: | | ||
if [ "$RUNNER_OS" == "Windows" ]; then | ||
pwsh -Command "7z x compressed-build.zip -aoa -o${{ github.workspace }}" | ||
else | ||
unzip -o compressed-build.zip | ||
fi | ||
ls -R | ||
- name: Integration tests (${{ matrix.browser }}) | ||
run: yarn test-api-${{ matrix.browser }} --headless --forbid-only | ||
|
||
release-dry-run: | ||
needs: build | ||
runs-on: ubuntu-latest | ||
|
Oops, something went wrong.