Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate shell path before displaying in picker #11

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Validate shell path before displaying in picker #11

merged 1 commit into from
Dec 11, 2017

Conversation

Jared-Miller
Copy link
Contributor

Checks shell paths to see if they exist and can be executed before showing them in the quick pick dropdown (#2).

@Tyriar
Copy link
Owner

Tyriar commented Dec 11, 2017

Looks great! Sorry about the delay, was on vacation and busy with personal stuff 😃

@Tyriar Tyriar merged commit 5ca536d into Tyriar:master Dec 11, 2017
@chentel
Copy link

chentel commented Dec 12, 2017

@Tyriar Relative paths not working for me anymore after 5ca536d (Windows)

@Tyriar
Copy link
Owner

Tyriar commented Dec 12, 2017

@chentel what are the path's relative to? Workspace root?

@chentel
Copy link

chentel commented Dec 12, 2017

@Tyriar in config settings

works:
{ "shell": "C:\\Windows\\System32\\bash.exe", "label": "WSL Bash" }

no longer works and shells not added to pick list:
{ "shell": "bash.exe", "label": "WSL Bash" }

@Tyriar
Copy link
Owner

Tyriar commented Dec 12, 2017

Oh items in your path, good point. Will fix up now

@Tyriar
Copy link
Owner

Tyriar commented Dec 12, 2017

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants