Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in loading the timing (and perhaps not only that) of the subtitles in an MKS. #91

Open
VegethB opened this issue Nov 19, 2020 · 3 comments

Comments

@VegethB
Copy link

VegethB commented Nov 19, 2020

I realized that Aegisub misloads subtitles included in MKS with subtitles only.
In short, of each anime series I am making a backup of the subtitles but inside an MKS (this is because MKS also allows you to keep attachments / fonts together and makes my life easier if I have to put them on other video tracks, ex: BD).

I can guarantee that the problem (from a simple point of view) is Aegisub's:

  1. SubtitleEdit opens subtitles without problems (and also loads the fonts even if they are not installed on the PC);
  2. If I extract the subtitle from the MKS and open it with Aegisub, there is no problem;
  3. If I mux the MKS on the video track, the subtitles start with the right timing (if it is the same track of course).

Luckily I noticed this, I don't know how many blasphemies ... if it was a bug of MKVToolNix.

I add that even in some cases it also moves the lines (some lines such as comments are placed at the top of the script)

Thank you in advance.

Here are two examples and files to try using:

MKS: https://mega.nz/file/1tF3XKjQ#lx8Eaa47SvChy6QuMphRyJxoGti3mjj7MyEaX3btteI
ASS: https://mega.nz/file/ZhUVkCgI#d5Kk64w1oSgPM8ssGyboX2qq2n1Qj1N1NfkcO-U0574
Video Source: https://nyaa.si/view/1304005

Original file with the right times:
image

MKS opened by Aegisub (wrong times):
image

@yairm210
Copy link

yairm210 commented Mar 1, 2021

Can confirm - for me, the timing seems to be relative to the start of the chapter rather than relative to the start of the video, and then when re-muxing it into the original video file, subtitles that were at the start of a chapter halfway through the video are now all the way at the beginning.

wangqr added a commit to wangqr/Aegisub that referenced this issue Apr 9, 2021
For normal media file, the starting timestamp is shifted to 0. This is necessary in order to playback trimmed audio/video that has a non-zero starting timestamp.
However, if the file only contains subtitle, we do not want to shift the start time of first line to 0. Because subtitles are never played alone, but usually attached to an audio/video. There is no way to get the starting timestamp of the audio/video in a subtitle-only MKV, so assuming 0 is a safe guess.

Fix TypesettingTools#91
@george-emerald
Copy link

This is still an issue, even though there's a commit here that references it. The timing is wrong whenever you open an mks file containing an ass file.

@FichteFoll
Copy link
Contributor

The change in the commit that references this issue seems reasonable to me and the commit message makes sense. However, it's not part of this repository (yet) and can be found in wangqr's fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants