Create a new pull request by comparing changes across two branches

.circleci/config.yml

@@ -13,13 +13,13 @@ version: 2.1
 var_1: &cache_key yarn-cache-{{ checksum "yarn.lock" }}-0.14.1
 var_2: &run_in_node
   docker:
-    - image: cimg/node:18.16.0
+    - image: cimg/node:18.16
 var_5: &run_in_browser
   docker:
-    - image: cimg/node:18.16.0-browsers
+    - image: cimg/node:18.16-browsers
 
 orbs:
-  browser-tools: circleci/[email protected].3
+  browser-tools: circleci/[email protected].4
 
 jobs:
   install:
@@ -69,7 +69,7 @@ jobs:
     <<: *run_in_browser
     steps:
       - checkout
-      - browser-tools/install-browser-tools
+      - browser-tools/install-chrome
       - run: |
           node --version
           google-chrome --version

.github/FUNDING.yml

@@ -1,9 +1,9 @@
 # These are supported funding model platforms
 
-github: # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
+github: [ngrx, brandonroberts] # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
 patreon: # Replace with a single Patreon username
 open_collective: ngrx
-ko_fi: # Replace with a single Ko-fi username
+ko_fi: timdeschryver # Replace with a single Ko-fi username
 tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
 community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
-custom: # Replace with a single custom sponsorship URL
+custom: https://ko-fi.com/markostanimirovic # Replace with a single custom sponsorship URL

.github/ISSUE_TEMPLATE.md

@@ -1,4 +1,4 @@
-<!-- ❤️ ngrx? Please consider supporting our collective: 👉  [donate](https://opencollective.com/ngrx/donate) -->
+<!-- ❤️ ngrx? Please consider sponsoring us: 👉  [sponsor](https://github.com/sponsors/ngrx) -->
 
 ## I'm submitting a...
 

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -5,7 +5,7 @@ body:
   - type: markdown
     attributes:
       value: |
-        ❤️ ngrx? Please consider supporting our collective: 👉  [donate](https://opencollective.com/ngrx/donate)
+        ❤️ ngrx? Please consider sponsoring us: 👉  [sponsor](https://github.com/sponsors/ngrx)
         Please search GitHub for a similar issue or PR before submitting a new issue.
         If you need real-time help, join us on [Discord](https://discord.com/invite/ngrx).
 

.github/ISSUE_TEMPLATE/documentation-report.yml

@@ -6,7 +6,7 @@ body:
   - type: markdown
     attributes:
       value: |
-        ❤️ ngrx? Please consider supporting our collective: 👉  [donate](https://opencollective.com/ngrx/donate)
+        ❤️ ngrx? Please consider sponsoring us: 👉  [sponsor](https://github.com/sponsors/ngrx)
         Please search GitHub for a similar issue or PR before submitting a new issue.
         If you need real-time help, join us on [Discord](https://discord.com/invite/ngrx).
 

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -5,7 +5,7 @@ body:
   - type: markdown
     attributes:
       value: |
-        ❤️ ngrx? Please consider supporting our collective: 👉  [donate](https://opencollective.com/ngrx/donate)
+        ❤️ ngrx? Please consider sponsoring us: 👉  [sponsor](https://github.com/sponsors/ngrx)
         Please search GitHub for a similar issue or PR before submitting a new issue.
         If you need real-time help, join us on [Discord](https://discord.com/invite/ngrx).
 

CHANGELOG.md

@@ -1,3 +1,23 @@
+<a name="16.2.0"></a>
+
+# [16.2.0](https://github.com/ngrx/platform/compare/16.1.0...16.2.0) (2023-08-07)
+
+### Bug Fixes
+
+- **data:** make DataServiceError extend from Error ([#3988](https://github.com/ngrx/platform/issues/3988)) ([0b98a65](https://github.com/ngrx/platform/commit/0b98a65))
+- **effects:** register functional effects from object without prototype ([#3984](https://github.com/ngrx/platform/issues/3984)) ([1879cc9](https://github.com/ngrx/platform/commit/1879cc9)), closes [#3972](https://github.com/ngrx/platform/issues/3972)
+- **eslint-plugin:** fix prefer-contact-latest-from rule to detect inject ([#3946](https://github.com/ngrx/platform/issues/3946)) ([2efd805](https://github.com/ngrx/platform/commit/2efd805))
+- **eslint-plugin:** prefix-selectors-with-select suggestion ([#3959](https://github.com/ngrx/platform/issues/3959)) ([27f09df](https://github.com/ngrx/platform/commit/27f09df))
+- **eslint-plugin:** support inject for no-typed-global-store rule ([#3951](https://github.com/ngrx/platform/issues/3951)) ([d3e84d8](https://github.com/ngrx/platform/commit/d3e84d8))
+- **eslint-plugin:** support inject for use-consistent-global-store-name rule ([#3983](https://github.com/ngrx/platform/issues/3983)) ([caa74ff](https://github.com/ngrx/platform/commit/caa74ff))
+- **store-devtools:** resolve memory leak when devtools are destroyed ([#3965](https://github.com/ngrx/platform/issues/3965)) ([644f0b6](https://github.com/ngrx/platform/commit/644f0b6))
+
+### Features
+
+- **eslint-plugin:** include docs URL in lint message ([#3944](https://github.com/ngrx/platform/issues/3944)) ([a1576de](https://github.com/ngrx/platform/commit/a1576de))
+- **schematics:** add entity generation as part of feature schematic ([#3850](https://github.com/ngrx/platform/issues/3850)) ([19ebb0a](https://github.com/ngrx/platform/commit/19ebb0a))
+- **store-devtools:** provide the ability to connect extension outside of Angular zone ([#3970](https://github.com/ngrx/platform/issues/3970)) ([1ee80e5](https://github.com/ngrx/platform/commit/1ee80e5)), closes [#3839](https://github.com/ngrx/platform/issues/3839)
+
 <a name="16.1.0"></a>
 
 # [16.1.0](https://github.com/ngrx/platform/compare/16.0.1...16.1.0) (2023-07-06)

CONTRIBUTING.md

@@ -26,7 +26,7 @@ yarn test
 
 ```shell
 yarn nx test effects --watchAll
-yarn nx test <library name that matches angular.json entry> --watchAll
+yarn nx test <module-name> --watchAll
 ```
 
 ### Testing for a specific schematic unit test
@@ -180,35 +180,8 @@ AFTER:
 New code example here
 ```
 
-## Financial contributions
+## Financial Contributions
 
-We also welcome financial contributions in full transparency on our [open collective](https://opencollective.com/ngrx).
-Anyone can file an expense. If the expense makes sense for the development of the community, it will be "merged" in the ledger of our open collective by the core contributors and the person who filed the expense will be reimbursed.
-
-## Credits
-
-### Contributors
+We also welcome sponsorships through [GitHub Sponsors](https://github.com/sponsors/ngrx). Sponsorships aid in the continued development of NgRx libraries, along with supporting core contributors on the project. If you are looking for more hands-on support such as training or workshops, check out our [Enterprise Support](https://ngrx.io/enterprise-support) page.
 
 Thank you to all the people who have already contributed to NgRx!
-<a href="https://github.com/ngrx/platform/graphs/contributors"><img src="https://opencollective.com/ngrx/contributors.svg?width=890" /></a>
-
-### Backers
-
-Thank you to all our backers! [[Become a backer](https://opencollective.com/ngrx#backer)]
-
-<a href="https://opencollective.com/ngrx#backers" target="_blank"><img src="https://opencollective.com/ngrx/backers.svg?width=890"></a>
-
-### Sponsors
-
-Thank you to all our sponsors! (please ask your company to also support this open source project by [becoming a sponsor](https://opencollective.com/ngrx#sponsor))
-
-<a href="https://opencollective.com/ngrx/sponsor/0/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/0/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/1/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/1/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/2/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/2/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/3/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/3/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/4/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/4/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/5/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/5/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/6/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/6/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/7/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/7/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/8/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/8/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/sponsor/9/website" target="_blank"><img src="https://opencollective.com/ngrx/sponsor/9/avatar.svg"></a>

README.md

@@ -1,9 +1,8 @@
 # @ngrx
 
-Reactive libraries for Angular
+Reactive State for Angular
 
 [![CircleCI](https://circleci.com/gh/ngrx/platform/tree/main.svg?style=shield)](https://circleci.com/gh/ngrx/workflows/platform/tree/main)
-[![Join the chat at https://gitter.im/ngrx/platform](https://badges.gitter.im/ngrx/platform.svg)](https://gitter.im/ngrx/platform?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![Join the discord server at https://discord.com/invite/ngrx](https://img.shields.io/discord/740557383109050469.svg?color=7389D8&labelColor=6A7EC2&logo=discord&logoColor=ffffff&style=flat-square)](https://discord.com/invite/ngrx)
 [![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](https://commitizen.github.io/cz-cli/)
 [![npm version](https://badge.fury.io/js/%40ngrx%2Fstore.svg)](https://www.npmjs.com/@ngrx/store)
@@ -18,35 +17,28 @@ NgRx is a community-driven project. Read our [contributing guidelines](./CONTRIB
 
 ## Sponsoring NgRx
 
-[![Backers on Open Collective](https://opencollective.com/ngrx/tiers/backers/badge.svg)](#backers)
-
-Become a gold sponsor and get your logo on our README on GitHub and the front page of [ngrx.io](https://ngrx.io).
+Sponsorships aid in the continued development and maintenance of NgRx libraries, along with supporting core contributors on the project. Consider asking your company to sponsor NgRx as its core to their business and application development.
 
 ### Gold Sponsors
 
-<a href="https://opencollective.com/ngrx/tiers/gold-sponsors/0/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/gold-sponsors/0/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/gold-sponsors/1/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/gold-sponsors/1/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/gold-sponsors/2/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/gold-sponsors/2/avatar.svg"></a>
+<a href="https://nx.dev" target="_blank">
+  <img src="https://github.com/ngrx/platform/blob/main/projects/ngrx.io/src/assets/images/sponsors/nx.svg" width="200px" height="200px" alt="NxDevTools logo">
+</a>
 
-### Silver Sponsors
+Become a gold sponsor and get your logo on our README on GitHub and the front page of [ngrx.io](https://ngrx.io).
 
-Become a silver sponsor and get your logo on our README on GitHub and our website [ngrx.io](https://ngrx.io).
+### Silver Sponsors
 
-<a href="https://opencollective.com/ngrx/tiers/silver-sponsors/0/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/silver-sponsors/0/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/silver-sponsors/1/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/silver-sponsors/1/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/silver-sponsors/2/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/silver-sponsors/2/avatar.svg"></a>
+Become a silver sponsor and get your logo on our README on GitHub.
 
 ### Bronze Sponsors
 
+<a href="https://houseofangular.io" target="_blank">
+  <img src="https://github.com/ngrx/platform/blob/main/projects/ngrx.io/src/assets/images/sponsors/house-of-angular.png" width="50px" height="50px" alt="House of Angular" />
+</a>
+
 Become a bronze sponsor and get your logo on our README on GitHub.
 
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/0/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/0/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/1/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/1/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/2/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/2/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/3/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/3/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/4/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/4/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/5/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/5/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/6/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/6/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/7/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/7/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/8/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/8/avatar.svg"></a>
-<a href="https://opencollective.com/ngrx/tiers/bronze-sponsors/9/website" target="_blank"><img src="https://opencollective.com/ngrx/tiers/bronze-sponsors/9/avatar.svg"></a>
+## Enterprise Support
+
+If your team or your company is looking for more hands-on support such as training or workshops, check out our [Enterprise Support](https://ngrx.io/enterprise-support) page.

build/config.ts

@@ -20,7 +20,8 @@ export const packages: PackageDescription[] = fs
       return false;
     }
 
-    if (path.includes('eslint-plugin')) {
+    // TODO: Remove signals when released as a stable package
+    if (path.includes('eslint-plugin') || path.includes('signals')) {
       return false;
     }
 

build/copy-schematics-core.ts

@@ -8,7 +8,8 @@ const copySchematics = createBuilder([
 
 copySchematics({
   scope: '@ngrx',
-  packages,
+  // TODO: Remove signals when released as a stable package
+  packages: [...packages, { name: 'signals' }],
 }).catch((err) => {
   console.error(err);
   process.exit(1);

build/publish-latest.ts

@@ -1,17 +1,23 @@
 import { createBuilder } from './util';
 import { packages } from './config';
 import * as shelljs from 'shelljs';
-import { readFileSync } from 'fs-extra';
 
 /**
  * Publish release to NPM on "latest" tag
  */
 export async function publishLatestToNpm() {
-  const configJSON = JSON.parse(readFileSync('./angular.json').toString());
-  const projects = configJSON.projects;
-  const publishablePackages = Object.keys(projects).filter(
-    (project) => !!projects[project].architect['build-package']
-  );
+  const publishablePackages = [
+    'store',
+    'effects',
+    'router-store',
+    'store-devtools',
+    'entity',
+    'component-store',
+    'component',
+    'schematics',
+    'eslint-plugin',
+    'data',
+  ];
 
   for (let pkg of publishablePackages) {
     console.log(`Publishing @ngrx/${pkg}`);

build/publish-next.ts

@@ -1,17 +1,23 @@
 import { createBuilder } from './util';
 import { packages } from './config';
 import * as shelljs from 'shelljs';
-import { readFileSync } from 'fs-extra';
 
 /**
  * Publish release to NPM on "next" tag
  */
 export async function publishNextToNpm() {
-  const configJSON = JSON.parse(readFileSync('./angular.json').toString());
-  const projects = configJSON.projects;
-  const publishablePackages = Object.keys(projects).filter(
-    (project) => !!projects[project].architect['build-package']
-  );
+  const publishablePackages = [
+    'store',
+    'effects',
+    'router-store',
+    'store-devtools',
+    'entity',
+    'component-store',
+    'component',
+    'schematics',
+    'eslint-plugin',
+    'data',
+  ];
 
   for (let pkg of publishablePackages) {
     console.log(`Publishing @ngrx/${pkg}`);

modules/component-store/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngrx/component-store",
-  "version": "16.1.0",
+  "version": "16.2.0",
   "description": "Reactive store for component state",
   "repository": {
     "type": "git",

modules/component-store/schematics-core/utility/libs-version.ts

@@ -1 +1 @@
-export const platformVersion = '^16.1.0';
+export const platformVersion = '^16.2.0';

modules/component/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngrx/component",
-  "version": "16.1.0",
+  "version": "16.2.0",
   "description": "Reactive Extensions for Angular Components",
   "repository": {
     "type": "git",

modules/component/schematics-core/utility/libs-version.ts

@@ -1 +1 @@
-export const platformVersion = '^16.1.0';
+export const platformVersion = '^16.2.0';

modules/data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngrx/data",
-  "version": "16.1.0",
+  "version": "16.2.0",
   "description": "API management for NgRx",
   "repository": {
     "type": "git",
@@ -22,9 +22,9 @@
   "peerDependencies": {
     "@angular/common": "^16.0.0",
     "@angular/core": "^16.0.0",
-    "@ngrx/store": "16.1.0",
-    "@ngrx/effects": "16.1.0",
-    "@ngrx/entity": "16.1.0",
+    "@ngrx/store": "16.2.0",
+    "@ngrx/effects": "16.2.0",
+    "@ngrx/entity": "16.2.0",
     "rxjs": "^6.5.3 || ^7.5.0"
   },
   "schematics": "./schematics/collection.json",

modules/data/schematics-core/utility/libs-version.ts

@@ -1 +1 @@
-export const platformVersion = '^16.1.0';
+export const platformVersion = '^16.2.0';

modules/data/src/dataservices/data-service-error.ts

@@ -7,13 +7,12 @@ import { RequestData } from './interfaces';
  * @param error the HttpErrorResponse or the error thrown by the service
  * @param requestData the HTTP request information such as the method and the url.
  */
-// If extend from Error, `dse instanceof DataServiceError` returns false
-// in some (all?) unit tests so don't bother trying.
-export class DataServiceError {
-  message: string | null;
-
+export class DataServiceError extends Error {
   constructor(public error: any, public requestData: RequestData | null) {
-    this.message = typeof error === 'string' ? error : extractMessage(error);
+    super(
+      typeof error === 'string' ? error : extractMessage(error) ?? undefined
+    );
+    this.name = this.constructor.name;
   }
 }
 

modules/effects/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngrx/effects",
-  "version": "16.1.0",
+  "version": "16.2.0",
   "description": "Side effect model for @ngrx/store",
   "repository": {
     "type": "git",
@@ -22,7 +22,7 @@
   "homepage": "https://github.com/ngrx/platform#readme",
   "peerDependencies": {
     "@angular/core": "^16.0.0",
-    "@ngrx/store": "16.1.0",
+    "@ngrx/store": "16.2.0",
     "rxjs": "^6.5.3 || ^7.5.0"
   },
   "schematics": "./schematics/collection.json",

modules/effects/schematics-core/utility/libs-version.ts

@@ -1 +1 @@
-export const platformVersion = '^16.1.0';
+export const platformVersion = '^16.2.0';