add test to cover case where interface has a "this" property and a type literal #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think I forgot to write the scenario correctly. There is definitely an issue. Did you try instead interface Test {
a: { b: 2}
c: this
} |
|
Interesting, the build fails when the "this" property is declared after the type literal... I'll update the test and work on it |
…pe literal property and fix the problem Problem fixed creating a getDescriptor function for type literal so that type literal don't modify the declaration node in the scope
|
Done, this is now ready for review @uittorio |
uittorio
approved these changes
Nov 20, 2019
|
thanks!!!! I hope it was not too difficult to find the issue! |
|
if you merge remember to use something like this, so it will appear on the changeling fix(this): make sure literal type will not interfere with "this" reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows that #88 is not relevant, let me know if I'm doing anything wrong here