chore(transformer): Enforce definitive signature for getDeclarationKeyMap and add a comment to why we can do that #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjlowm
force-pushed
the
chore/enforce-definitive-signature-get-declaration-key-map
branch
from
e0353ee to
11abd1b
Compare
…yMap and add a comment to why we can do that
martinjlowm
force-pushed
the
chore/enforce-definitive-signature-get-declaration-key-map
branch
from
11abd1b to
5bed4df
Compare
uittorio
reviewed
May 16, 2020
uittorio
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it was me that changed this originally, but I've come to realize that it only adds noise to the code.
Now there's a comment that explains why the cast is okay.
This PR follows #313