fix: Prevent @hidden signature from removing method declaration

[socsieng]

For #1142

The declaration was being treat as hidden when applyModifiers was being called. This change determines if the reflection is hidden during resolution instead.

[socsieng]

I couldn't find a way to remove sources from signatures that have been removed.

[Gerrit0]

I think this is OK, but will see if I notice an easy way to do it

[Gerrit0]

Removing reflections during resolution poses a problem - if a reference is later created pointing to that reflection it will be reported as as a broken reference.

This is part of the problem posed in #1166. When the reflection is removed determines whether or not you get a broken reference.

[socsieng]

Removing reflections during resolution poses a problem

This is consistent with existing behavior. Isn't the resolution process the right time to remove reflections?

if a reference is later created pointing to that reflection it will be reported as as a broken reference

Creating reflections after/during the resolution process seems like the wrong time to be doing this.

[Gerrit0]

Sorry, just looking at the diff misled me, I thought they were being removed in the onDeclaration method. Yes you are correct, that's the right time to do this. Let me pull it down and play with it locally and it should be good to merge 👍