Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After migrating from 0.19.2 to 0.20.5 typedoc is throwing error #1439

Closed
hassanazharkhan opened this issue Jan 1, 2021 · 3 comments
Closed

After migrating from 0.19.2 to 0.20.5 typedoc is throwing error #1439

hassanazharkhan opened this issue Jan 1, 2021 · 3 comments
Labels
bug Functionality does not match expectation

Comments

@hassanazharkhan
Copy link

hassanazharkhan commented Jan 1, 2021 •
edited
Loading

Typedoc failed to generate documentation using 0.20.5 while it is working with 0.19.2

Error:

Screenshot 2021-01-01 at 9 01 33 AM

Environment

  • Typedoc version: 0.20.5
  • TypeScript version: 3.9.7
  • Node.js version: 14.5
  • OS: Mac/bigSur
@hassanazharkhan hassanazharkhan added the bug Functionality does not match expectation label Jan 1, 2021
@hassanazharkhan
Copy link
Author

The same issue also exists in 0.20.6 which has just been tested

Gerrit0 added a commit that referenced this issue Jan 1, 2021
@Gerrit0
fix: Tuples could cause a crash
b4da1ca 
Semi-fix for #1439. Really need a test case.
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 1, 2021

I really wish I could reproduce it... fixing it isn't that difficult (0.20.7), but I played around for a while and wasn't able to get the issue to show up. Is there any chance you have seen this in an open source project that I could debug?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 1, 2021

Oh... I feel dumb now. The cause of this was the old TS version. elements was called elementTypes in 3.9.
I really need to set up a way for typedoc's tests to run on multiple TS versions to detect this sooner.

@Gerrit0 Gerrit0 closed this as completed Jan 1, 2021
@Gerrit0 Gerrit0 mentioned this issue Jan 1, 2021
Closed
KengoTODA added a commit to KengoTODA/promisified-properties that referenced this issue Jan 1, 2021
@KengoTODA
chore: bump up typedoc to the latest
fb4feb7 
this is necessary to build doc with the latest ini.
TypeStrong/typedoc#1439

also addeed missing pretty-quick command required by the pre-commit hook
KengoTODA added a commit to KengoTODA/promisified-properties that referenced this issue Jan 1, 2021
@dependabot-preview @KengoTODA
fix(deps): [security] bump ini from 1.3.5 to 1.3.8 (#125)
94ff2c5 
* fix(deps): [security] bump ini from 1.3.5 to 1.3.8

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. **This update includes security fixes.**
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.8)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* chore: bump up typedoc to the latest

this is necessary to build doc with the latest ini.
TypeStrong/typedoc#1439

also addeed missing pretty-quick command required by the pre-commit hook

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Kengo TODA <[email protected]>
@eemeli eemeli mentioned this issue Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Functionality does not match expectation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gerrit0 @hassanazharkhan