Skip to content

Commit

Permalink
ReflectionSymbolId.pos uses getStart for position
Browse files Browse the repository at this point in the history
  • Loading branch information
Gerrit0 committed Oct 3, 2024
1 parent 40d1cec commit d349280
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,20 @@

- Updated Chinese translations, #2706.
- Exported constants no longer render the type and default value if they are the same, #2717.
- The HTML output now wraps tag blocks with `<div>` tags and includes the tag name in a class name, #2723.

### Bug Fixes

- Correctly handle external link resolver link text when referencing an external symbol, #2700.
- Big integer literals are now supported as default values, #2721.
- Corrected handling of `@link` tags present in comments at the start of source files.
- `ReflectionSymbolId.pos` no longer references the position _before_ any doc comments for a symbol.
This could cause typedoc-plugin-dt-links to produce links which didn't go to the expected location in a file.

### Thanks!

- @Corso02
- @lriggle-strib
- @XeroAlpha

## v0.26.7 (2024-09-09)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/models/reflections/ReflectionSymbolId.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class ReflectionSymbolId {
} else {
this.qualifiedName = getQualifiedName(symbol, symbol.name);
}
this.pos = declaration?.pos ?? Infinity;
this.pos = declaration?.getStart() ?? Infinity;
if (symbol.flags & ts.SymbolFlags.Transient) {
this.transientId = transientIds.get(symbol) ?? ++transientCount;
transientIds.set(symbol, this.transientId);
Expand Down

0 comments on commit d349280

Please sign in to comment.