Fix comments on function types

Resolves #2336

CHANGELOG.md

@@ -13,6 +13,7 @@
 
 ### Bug Fixes
 
+-   Methods which return function types no longer have duplicated comments, #2336.
 -   Fix crash when converting some complicated union/intersection types, #2451.
 -   Navigation triangle markers should no longer display on a separate line with some font settings, #2457.
 -   `@group` and `@category` organization is now applied later to allow inherited comments to create groups/categories, #2459.

src/lib/converter/comments/discovery.ts

@@ -360,11 +360,7 @@ function declarationToCommentNode(node: ts.Declaration): ts.Node | undefined {
         return node.parent.parent;
     }
 
-    if (
-        [ts.SyntaxKind.NamespaceExport, ts.SyntaxKind.FunctionType].includes(
-            node.kind,
-        )
-    ) {
+    if (ts.SyntaxKind.NamespaceExport === node.kind) {
         return node.parent;
     }
 

src/test/converter2/issues/gh2336.ts

@@ -0,0 +1,13 @@
+export class ClassVersion {
+    /**
+     * Outer
+     * @returns Returns Outer
+     */
+    outer(): () => void {
+        /**
+         * Inner
+         * @returns Returns Inner
+         */
+        return () => {};
+    }
+}

src/test/issues.c2.test.ts

@@ -1128,6 +1128,21 @@ describe("Issue Tests", () => {
         equal(tp.flags.isConst, true);
     });
 
+    it("Handles comments with nested methods #2336", () => {
+        const project = convert();
+
+        const outer = querySig(project, "ClassVersion.outer");
+        equal(Comment.combineDisplayParts(outer.comment?.summary), "Outer");
+
+        equal(outer.type?.type, "reflection");
+        equal(
+            Comment.combineDisplayParts(
+                outer.type.declaration.signatures![0].comment?.summary,
+            ),
+            "",
+        );
+    });
+
     it("Supports nested paths with tsLinkResolution #2360", () => {
         const project = convert();
         const x = query(project, "x");