Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
- Move JSON types out of the namespace
- Introduce a helper to semi-automatically conver types to their JSON equivalent
- Address all the build errors caused by removing the namespace
  • Loading branch information
Gerrit0 committed Oct 14, 2019
1 parent f5b5837 commit 5a2fac6
Show file tree
Hide file tree
Showing 29 changed files with 281 additions and 295 deletions.
2 changes: 1 addition & 1 deletion src/lib/models/reflections/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export { Reflection, ReflectionKind, ReflectionFlag, TypeParameterContainer, Decorator, TraverseProperty } from './abstract';
export { Reflection, ReflectionKind, ReflectionFlag, TypeParameterContainer, Decorator, TraverseProperty, ReflectionFlags } from './abstract';
export { ContainerReflection } from './container';
export { DeclarationReflection, DeclarationHierarchy } from './declaration';
export { ParameterReflection } from './parameter';
Expand Down
6 changes: 3 additions & 3 deletions src/lib/serialization/events.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Event } from '../utils/events';
import { ProjectReflection } from '../models';
import { JSONOutput } from './schema';
import { ProjectReflection as JSONProjectReflection } from './schema';

/**
* Optional data associated with the [[SerializeEvent]].
Expand Down Expand Up @@ -33,9 +33,9 @@ export class SerializeEvent extends Event {
*/
outputFile?: string;

output: Partial<JSONOutput.ProjectReflection>;
output: Partial<JSONProjectReflection>;

constructor(name: string, project: ProjectReflection, output: Partial<JSONOutput.ProjectReflection>) {
constructor(name: string, project: ProjectReflection, output: Partial<JSONProjectReflection>) {
super(name);
this.project = project;
this.output = output;
Expand Down
3 changes: 2 additions & 1 deletion src/lib/serialization/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@ export {

export { SerializeEvent } from './events';

export { JSONOutput } from './schema';
import * as JSONOutput from './schema';
export { JSONOutput };
Loading

0 comments on commit 5a2fac6

Please sign in to comment.