Fix invalid link handling in packages mode

Resolves #2403
TypeStrong · Oct 6, 2023 · 2cabd22 · 2cabd22
1 parent 608cf48
commit 2cabd22
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 ### Bug Fixes
 
+-   Invalid link validation is now correctly suppressed before all projects have been converted in packages mode, #2403.
 -   Fixed tsconfig handling for projects using a solution-style tsconfig, #2406.
 -   Fixed broken settings icons caused by icon caching introduced in 0.25.1, #2408.
 

diff --git a/src/lib/application.ts b/src/lib/application.ts
@@ -594,9 +594,9 @@ export class Application extends ChildableComponent<
         for (const dir of packageDirs) {
             this.logger.info(`Converting project at ${nicePath(dir)}`);
             const opts = origOptions.copyForPackage(dir);
+            await opts.read(this.logger, dir);
             // Invalid links should only be reported after everything has been merged.
             opts.setValue("validation", { invalidLink: false });
-            await opts.read(this.logger, dir);
             if (
                 opts.getValue("entryPointStrategy") ===
                 EntryPointStrategy.Packages