Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

major updates to typescript build config #65

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

aciccarello
Copy link
Contributor

  • Pulls out the typescript config into a tsconfig.json file
  • Adds libraries as node dependencies
  • Uses @types packages for type definitions
  • Replaces module with namespace
  • Fixes strict errors

Copy link
Contributor

@Gerrit0 Gerrit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm always happy to see strict mode on.

@aciccarello aciccarello merged commit 09a193e into master Mar 22, 2019
@aciccarello aciccarello deleted the cleanup-build branch March 22, 2019 13:38
@jonchardy
Copy link
Contributor

Are search and visibility toggles broken by this update? They don't seem to be working for me when I pull these changes down to our project.

It seems to reverse some changes that went with #43 to ensure the components are concatenated in the right order for compilation.

@aciccarello
Copy link
Contributor Author

@jonchardy I think you may be right about the order being incorrect. We probably should add /// <reference> comments or switch to actual modules so dependencies are explicit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants