This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 130
Convert templates from .hbs to .tsx #137
Draft
cspotcode
wants to merge
19
commits into
TypeStrong:master
Choose a base branch
from
cspotcode:jsx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was nerd-sniped by our discussion on Discord, so I tried to automatically convert the .hbs into .tsx This is as far as I got.
convert.ts
attempts to use a third-party library to do the conversion. It complains about some stuff that I've been manually find-and-replacing.TODO
item
andprops
variables. Using both was a hack because the hbs to jsx converter usesitem
for#each
iteration butprops
for the top-level props object.Theme
interface; import and consolidate all functions into a singleTheme
instanceIfCond
invocations to pass a boolean wrapped in{}
IfCond
entirely, but would be annoying for an MVPIfSignature
Markdown
Collapse
: what even is this?className
conditionals that I hacked away to please the converter