Fix service host interface to support ts2.5 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
reviewed
Jun 21, 2017
src/index.ts
Outdated
| @@ -278,6 +278,9 @@ export function register (options: Options = {}): Register { | |||
| }, | |||
| getDirectories: getDirectories, | |||
| directoryExists: directoryExists, | |||
| fileExists: ts.sys.fileExists, | |||
| readFile: ts.sys.readFile, | |||
| readDirectory: ts.sys.readDirectory, | |||
There was a problem hiding this comment.
We have existing implementations of two of these functions, should we just use those?
|
@blakeembrey - do you know if we need to make a similar change to ts-loader here: https://github.com/TypeStrong/ts-loader/blob/master/src/servicesHost.ts#L34 ? |
|
@johnnyreilly I would think so, yes. You can just use the |
|
Thanks @blakeembrey - I've tested and it looks good. |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript 2.5 language service host needs to implement fileExists, readFile and readDirectory to be able to correctly resolve the modules (otherwise only ambient modules would be resolved)
Described here https://github.com/Microsoft/TypeScript/blame/master/src/services/types.ts#L166