Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP adapting to sync resolve; cleaning up esm hook stuff #1804

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP adapting to sync resolve; cleaning up esm hook stuff #1804

wants to merge 3 commits into from

Conversation

cspotcode
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 20, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (bf13086) to head (83ebb8a).
Report is 49 commits behind head on main.

Files Patch % Lines
src/esm.ts 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files Coverage Δ
src/child/child-loader.ts 88.88% <100.00%> (ø)
src/esm.ts 84.37% <85.71%> (+1.04%) ⬆️

@cspotcode
Copy link
Collaborator Author

node rolled back the sync resolve change, so I can extract the ESM cleanup stuff from this PR but drop all the sync resolve stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cspotcode