Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1282: correct globals in [stdin], [eval], and <repl> contexts #1333

Merged
merged 20 commits into from
Jun 8, 2021

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented May 23, 2021

Fixes #1282.

Also attempts a partial solution to #1370, an unrelated issue with flaky windows tests caused by npm.

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #1333 (297c372) into main (4f16d1b) will increase coverage by 0.36%.
The diff coverage is 92.39%.

Impacted Files Coverage Δ
dist-raw/node-primordials.js 60.00% <50.00%> (+10.00%) ⬆️
src/repl.ts 73.72% <79.16%> (+0.21%) ⬆️
src/bin.ts 91.40% <97.95%> (+0.58%) ⬆️
dist-raw/node-cjs-helpers.js 100.00% <100.00%> (ø)
src/util.ts 90.62% <100.00%> (+0.62%) ⬆️
src/index.ts 77.91% <0.00%> (-0.51%) ⬇️

@cspotcode cspotcode changed the title Fix #1282 Fix #1282: correct globals in [stdin], [eval], and <repl> contexts Jun 1, 2021
@cspotcode cspotcode marked this pull request as ready for review June 6, 2021 20:01
@cspotcode cspotcode merged commit 6266ae2 into main Jun 8, 2021
@cspotcode cspotcode added this to the 10.x.x milestone Jun 8, 2021
@cspotcode cspotcode deleted the ab/evaluate-with-module-globals branch October 11, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPL, -e, and piped stdin globals are wrong: ,missing exports, module, etc.
1 participant