Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage #1109

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Add test coverage #1109

merged 4 commits into from
Aug 12, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Aug 11, 2020

Some of these tests are silly, but they were easy to implement and bump the coverage up. I personally don't believe in coverage numbers out of context, but I know other people (incorrectly) do, so why not?

Blocked by #1103 which will be merged soon

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #1109 into master will increase coverage by 3.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   75.68%   78.87%   +3.19%     
==========================================
  Files           7        7              
  Lines         658      658              
  Branches      147      147              
==========================================
+ Hits          498      519      +21     
+ Misses        107       91      -16     
+ Partials       53       48       -5     
Flag Coverage Δ
#node_10 75.42% <ø> (+3.02%) ⬆️
#node_12_15 75.80% <ø> (+3.02%) ⬆️
#node_12_16 75.80% <ø> (+3.02%) ⬆️
#node_13 78.57% <ø> (+3.19%) ⬆️
#node_14 78.57% <ø> (+3.19%) ⬆️
#typescript_2_7 78.41% <ø> (+3.19%) ⬆️
#typescript_latest 77.65% <ø> (+3.19%) ⬆️
#typescript_next 77.50% <ø> (+3.19%) ⬆️
#ubuntu 78.57% <ø> (+3.19%) ⬆️
#windows 78.72% <ø> (+3.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 79.60% <0.00%> (+1.41%) ⬆️
src/bin.ts 76.30% <0.00%> (+6.35%) ⬆️
src/esm.ts 80.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29ae04...98dc6f5. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 12, 2020

Coverage Status

Coverage increased (+4.2%) to 86.454% when pulling 98dc6f5 on ab/esm-loader-test-deferred-urls into e29ae04 on master.

@cspotcode cspotcode changed the title Test ESM loader "defer" codepaths Add test coverage Aug 12, 2020
@cspotcode cspotcode marked this pull request as ready for review August 12, 2020 23:02
@cspotcode cspotcode force-pushed the ab/esm-loader-test-deferred-urls branch from 64256d8 to 98dc6f5 Compare August 12, 2020 23:07
@cspotcode cspotcode merged commit 7cb6d57 into master Aug 12, 2020
@cspotcode cspotcode mentioned this pull request Aug 21, 2020
4 tasks
@cspotcode cspotcode deleted the ab/esm-loader-test-deferred-urls branch January 18, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants