Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage and testing badges #1095

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Aug 8, 2020

Codecov reports 75% coverage; coveralls reports 82%. I might try to figure out the discrepancy, but that's pretty low-priority.

EDIT: codecov explains their formula here:
https://docs.codecov.io/docs/about-code-coverage#codecov-calculations

I couldn't find a clear doc for coveralls, though I see it reporting both branch coverage percentage, and "relevant lines covered" percentage. codecov's number is somewhere between these two.

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #1095 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files           7        7           
  Lines         657      657           
  Branches      148      148           
=======================================
  Hits          496      496           
  Misses        107      107           
  Partials       54       54           
Flag Coverage Δ
#node_10 72.15% <ø> (ø)
#node_12_15 72.53% <ø> (ø)
#node_12_16 72.53% <ø> (ø)
#node_13 75.19% <ø> (ø)
#node_14 75.19% <ø> (ø)
#typescript_2_7 75.03% <ø> (ø)
#typescript_latest 74.27% <ø> (ø)
#typescript_next 74.12% <ø> (ø)
#ubuntu 75.19% <ø> (ø)
#windows 75.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490ed8a...141c4e1. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 8, 2020

Coverage Status

Coverage increased (+1.0%) to 83.175% when pulling 141c4e1 on ab/fix-coverage-and-test-badges into 490ed8a on master.

@cspotcode cspotcode merged commit 66732d6 into master Aug 13, 2020
@cspotcode cspotcode mentioned this pull request Aug 21, 2020
4 tasks
@cspotcode cspotcode deleted the ab/fix-coverage-and-test-badges branch January 18, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants