Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push coverage from GH Actions; remove TravisCI #1034

Merged
merged 14 commits into from
May 10, 2020
Merged

Push coverage from GH Actions; remove TravisCI #1034

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dcb61d2
attempt to push coverage from gh actions
cspotcode May 10, 2020
16cd59f
fix
cspotcode May 10, 2020
0c76da6
fix
cspotcode May 10, 2020
bc7e2b1
fix failing lint because node 6 npm install doesn't obey package-lock…
cspotcode May 10, 2020
d4c93d7
fix
cspotcode May 10, 2020
9d34f0f
Merge remote-tracking branch 'origin/master' into ab/move-coverage-to…
cspotcode May 10, 2020
09e437a
fix
cspotcode May 10, 2020
710273d
try using coveralls gh action
cspotcode May 10, 2020
8916096
parallel coveralls
cspotcode May 10, 2020
0b5020d
add nigthly test
cspotcode May 10, 2020
8d42e1f
try to force finish to run always
cspotcode May 10, 2020
adab3fb
try again
cspotcode May 10, 2020
cb76aab
fix
cspotcode May 10, 2020
033b021
remove intentially failing test
cspotcode May 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ jobs:
node-version: ${{ matrix.node }}
# lint, build, test
- run: npm install
- run: npm run lint
- run: npm run build
- run: npm rm tslint
- run: npm install ${{ matrix.typescript }}
- run: npm run test-cov
- run: npm install ${{ matrix.typescript }} --force
- run: set +e ; npm run test-cov ; echo $? > tests-exit-code
- run: npm install -g coveralls@2 && cat ./coverage/lcov.info | coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use if: ${{ always() }} instead: https://help.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#always.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was having so much trouble navigating the github actions docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been pretty challenging, but I've been using it in some private monorepos lately so got a bunch of first-hand experience (which seems to be the only way to learn).

- run: set -euo pipefail ; exit $(cat tests-exit-code)
27 changes: 0 additions & 27 deletions .travis.yml
View file
Open in desktop

This file was deleted.

Loading