You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there anywhere in the code where we check module configs? Or hardcode module enum values? If so, we should add tests that break whenever TS adds new module options we have not accounted for. That way our nightly tests will warn us when we may need code changes.
We need to prove that swc ModuleKind mapping includes relevant values, and that swc properly classifies modules in node12 and nodenext mode.
The text was updated successfully, but these errors were encountered:
cspotcode
changed the title
Dom our tests need to detect new "target" options?
Do our tests need to detect new "target" options?
Oct 12, 2021
cspotcode
changed the title
Do our tests need to detect new "target" options?
Do our tests need to detect new "module" options?
Oct 12, 2021
TS 4.5 introduces --module es2022
Is there anywhere in the code where we check module configs? Or hardcode module enum values? If so, we should add tests that break whenever TS adds new module options we have not accounted for. That way our nightly tests will warn us when we may need code changes.
We need to prove that swc
ModuleKind
mapping includes relevant values, and that swc properly classifies modules innode12
andnodenext
mode.The text was updated successfully, but these errors were encountered: