Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do our tests need to detect new "module" options? #1510

Closed
cspotcode opened this issue Oct 12, 2021 · 0 comments · Fixed by #1650
Closed

Do our tests need to detect new "module" options? #1510

cspotcode opened this issue Oct 12, 2021 · 0 comments · Fixed by #1650
Milestone

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Oct 12, 2021

TS 4.5 introduces --module es2022

Is there anywhere in the code where we check module configs? Or hardcode module enum values? If so, we should add tests that break whenever TS adds new module options we have not accounted for. That way our nightly tests will warn us when we may need code changes.


We need to prove that swc ModuleKind mapping includes relevant values, and that swc properly classifies modules in node12 and nodenext mode.

@cspotcode cspotcode changed the title Dom our tests need to detect new "target" options? Do our tests need to detect new "target" options? Oct 12, 2021
@cspotcode cspotcode changed the title Do our tests need to detect new "target" options? Do our tests need to detect new "module" options? Oct 12, 2021
@cspotcode cspotcode added this to the 10.6.0 or 10.5.1 milestone Feb 19, 2022
cspotcode added a commit that referenced this issue Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant