Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: disable GitHub Linguist detection for tests files #1368

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Chore: disable GitHub Linguist detection for tests files #1368

merged 1 commit into from
Aug 30, 2021

Conversation

sabertazimi
Copy link
Contributor

It makes TypeScript become the top language.

It makes TypeScript become the top language.
@johnnyreilly
Copy link
Member

Could you provide some more information please? I don't understand the intent of this PR.

@sabertazimi
Copy link
Contributor Author

sabertazimi commented Aug 30, 2021

Could you provide some more information please? I don't understand the intent of this PR.

You can refer to the repo GitHub Linguist for GitHub language detection service.
And you can refer to the forked repo WebPRs/ts-loader for viewing live demo.

When you viewing original ts-loader repo in browser, GitHub marks JavaScript as top language of ts-loader repo
via GitHub Linguist service.
But actually, all source files in ts-loader repo are written in TypeScript.
Most JavaScript files are located in directory test/.

GitHub allows you to change detection strategy in .gitattributes file.
After ignoring detection for files in directory test/, GtiHub marks TypeScript as top language of ts-loader repo.

@sabertazimi
Copy link
Contributor Author

type-strong

Only ts-loader is marked as a JavaScript repo. But actually, it's a TypeScript repo (due to all source files in directory src/ are written in TypeScript).

Copy link
Member

@johnnyreilly johnnyreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johnnyreilly johnnyreilly merged commit 2ea7466 into TypeStrong:main Aug 30, 2021
@sabertazimi
Copy link
Contributor Author

ts-loader
type-strong2

It works.

@sabertazimi sabertazimi deleted the chore/github-linguist branch August 30, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants