Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer dependencies for Yarn PnP #1209

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Add peer dependencies for Yarn PnP #1209

merged 1 commit into from
Nov 9, 2020

Conversation

aicest
Copy link
Contributor

@aicest aicest commented Nov 8, 2020

Desc: should explicitly indicate peer/optional dependency for yarn v2.

Reproducing bug: https://github.com/aicest/webpack-v5-demo

捕获

@johnnyreilly
Copy link
Member

Thanks - this seems like a good idea. Could you update the version in the package.json and add an entry to the CHANGELOG.md please?

@aicest
Copy link
Contributor Author

aicest commented Nov 9, 2020

@johnnyreilly done.

@johnnyreilly johnnyreilly merged commit 0816fe9 into TypeStrong:master Nov 9, 2020
@johnnyreilly
Copy link
Member

@haroldlbrown
Copy link

haroldlbrown commented Jan 27, 2021

Could it be that this issue is still present in 8.0.14?

I have migrated a NestJS project from npm to Yarn 2 PnP and now I am getting this error:

~/IdeaProjects/my-service on feature/yarn-migration ⇡3 ❯ yarn explain peer-requirements p0b548                                                                                                                                                                                                           at 17:36:06
➤ YN0000: my-service@workspace:. doesn't provide webpack, breaking the following requirements:

➤ YN0000: ts-loader@npm:8.0.14 [0b662] → * ✘

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants