-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getOptionsHash when two options has different props but same values. #1170
Fix getOptionsHash when two options has different props but same values. #1170
Conversation
There is still something wrong, let me find it out. |
The another issue is that I using |
For some reason the Travis build has failed... |
…correct serialization in `thread-loader`
Allow to use If
In this case we should use string instead of |
Looks good - do you want to add an entry to the By the way, you might not need thread-loader: https://blog.johnnyreilly.com/2018/12/you-might-not-need-thread-loader.html |
Just published https://github.com/TypeStrong/ts-loader/releases/tag/v8.0.3 - thanks for your work! 🤗🌻 |
Fix the issue when I use both
lang="tsx"
andlang="ts"
in vue single file components.For
lang="ts"
:For
lang="tsx"
:They get the same hash because
getOptionsHash
use only values for hashing.So for tsx vue file, it reuses the loader options which is only for ts vue, which add
.ts
suffix not.tsx
.That can lead to wrong compilation result.