-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update GitHub Actions #1144
update GitHub Actions #1144
Conversation
All tests which ran on GitHub Actions passed. AppVeyor and Travis CI won't succeed because I've deleted their configuration files. |
Nice work! Could you undelete the Travis and AppVeyor files please? I'd like to run them side by side for a while before decommissioning (though I'll probably not require them to pass before merging; just interested in looking at the difference) |
I will. While this question is not related to this PR, are there any plans for migrating the comparison tests to snapshot tests with Jest? |
Great question! I've long pondered doing something like that. It looks like webpack uses jest: https://github.com/webpack/webpack/blob/master/package.json#L122 I guess the problems to solve here are:
If you wanted to take a look, we'd greatly appreciate it! 🌻❤️ |
Yes, I know. And, can this PR be merged? |
Nice work! Thank you 😄 Assuming all goes well we'll look to drop AppVeyor soon |
Switched to GitHub Actions.