Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove eslint support #607

Merged
merged 2 commits into from
May 12, 2021
Merged

Conversation

piotr-oles
Copy link
Collaborator

Let's remove eslint support on alpha channel. I will remove unnecessary abstractions in the next PRs.
The goal of the 7.0.0 release is to drop support for Node 10 (as is no longer supported), webpack 4 (this will fix types issues), and old versions of TypeScript (2+ years old).
I will still try to maintain version 6 by fixing bugs :)

BREAKING CHANGE: 🧨 ESLint no longer supported by the plugin

BREAKING CHANGE: 🧨 ESLint no longer supported by the plugin
@piotr-oles piotr-oles requested a review from johnnyreilly May 7, 2021 20:34
@piotr-oles piotr-oles self-assigned this May 7, 2021
@piotr-oles piotr-oles merged commit 98e4f39 into alpha May 12, 2021
@piotr-oles piotr-oles deleted the feature/remove-eslint-support branch May 12, 2021 05:34
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 7.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cmlenz
Copy link

cmlenz commented May 12, 2021

I couldn't find any discussion about this, so I'm curious: what is the rationale behind removing ESLint support. And what is the recommended replacement for projects that use this now?

@piotr-oles
Copy link
Collaborator Author

#601 :)

piotr-oles added a commit that referenced this pull request Jan 29, 2022
* feat: use simple program for single compilation (no watch) (#574)

Use simple ts.Program and ts.CompilerHost when running webpack in
non-watch mode. This can improve check time in CI for some cases.

BREAKING CHANGE: 🧨 Use ts.Program and ts.CompilerHost for single compilation by default

✅ Closes: #572

* feat: remove eslint support (#607)

BREAKING CHANGE: 🧨 ESLint no longer supported by the plugin

* chore: merge main changes (#619)

* test: use karton for e2e tests (#627)

Use external package to handle e2e tests to simplify code base

* feat: drop support for webpack 4 (#638)

BREAKING CHANGE: 🧨 Webpack 4 is no longer supported. Please upgrade to Webpack ^5.11.0 or use an older version of the plugin.

* feat: improve error formatting to match webpack 4 convention (#641)

* feat: upgrade dependencies

Upgrade dependencies that doesn't require Node version bump.

* chore: remove unused dependencies

* feat: drop support for node 10

Node 10 is no longer maintained

BREAKING CHANGE: 🧨 Require Node.js >= 12

* chore: upgrade dev dependencies

* feat: remove support for TypeScript < 3.6.0 (#643)

BREAKING CHANGE: 🧨 Drop support for TypeScript < 3.6.0

* feat: port changes from main branch (#649)

This commit contains fixes from the main branch

* fix: require typescript@^3.8.0 for build: true mode (#672)

SolutionBuilder API is buggy for TypeScript < 3.8.0. To reduce maintenance burden, we bump minimal TypeScript version for { build: true } mode to 3.8.0.

BREAKING CHANGE: 🧨 Minimal version of TypeScript with { build: true } mode changed from 3.6.0 to 3.8.0

* refactor: add eslint rules to enforce import order (#671)

* feat: migrate from reporters to workers (#691)

Use simple functions and modules to simplify worker code

* refactor: rename files to match convention (#693)

I found snake-case easier to read, and given that
the project doesn't use OOP a lot, having all PascalCase
names doesn't reflect the paradigm and feels unnatural.

* feat: simplify logger options (#695)

Currently, the logger options are overcomplicated. To simplify them, we
are removing logger.infrastructure option.

BREAKING CHANGE: 🧨 Changes in options: `logger.issues` becomes `logger`, `logger.devServer`
becomes `devServer`, `logger.infrastructure` has been removed

* docs: add plugin logo (#696)

* refactor: upgrade project dependencies (#698)
@piotr-oles
Copy link
Collaborator Author

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants