Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit service concurrency #441

Closed
shadrech opened this issue Jun 8, 2020 · 8 comments · Fixed by #559
Closed

Limit service concurrency #441

shadrech opened this issue Jun 8, 2020 · 8 comments · Fixed by #559

Comments

@shadrech
Copy link

shadrech commented Jun 8, 2020

Feature motivation

I'm running this plugin in a serverless framework project. Now that I have multiple lambda functions this plugin is now taking up quite a lot of memory

Feature description

Is there a way to limit the amount of concurrent services it runs? So maybe an option saying process only 10 services at the same time, the others can wait

@piotr-oles
Copy link
Collaborator

Related: #424

@shadrech
Copy link
Author

shadrech commented Jun 8, 2020

@piotr-oles Thanks for swift reply!
It would be nice if this was a feature added to the plugin 🙈
As serverless framework and typescript become more popular I can see a lot of people using this plugin and coming across this issue. But I've just settled for the fork-ts-checker-webpack-plugin-limiter plugin 👍🏾

@stale
Copy link

stale bot commented Oct 11, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Oct 11, 2020
@TheNickmaster21
Copy link

I have not had luck using the fork-ts-checker-webpack-plugin-limiter. We have a severless repository containing 35 lambdas that are packaged and built separately. When running with this plugin, our build times are shorter but we have been getting crashes during build because of the memory and processing requirements of running 35 instances of this plugin at one time. Is there still not a clean way to limit the concurrency? Even when limiting parallelism in our webpack config, we end up with 35 node instances of this plugin running at once.

@stale stale bot removed the wontfix label Oct 19, 2020
@piotr-oles
Copy link
Collaborator

@TheNickmaster21 fork-ts-checker-webpack-plugin-limiter didn't work? I would not like to add this functionality to the plugin unless there is a higher demand for it. Adding new options to the API will increase complexity and maintenance costs :/

@TheNickmaster21
Copy link

It did not help for us. I tried the custom solution and the actual published npm package and neither seemed to work. We have actually switched to just doing a tsc --noEmit at the root of our project as a prebuild step instead of using this plugin. It takes only 30ish second and catches the same issues.

@vicary
Copy link

vicary commented Jan 5, 2021

@TheNickmaster21 I have a comprehensive explanation of my config on serverless and how things are stitched together, you may want to take a look at Enigmatic-Smile/serverless-plugin-optimize#72 (comment)

piotr-oles added a commit that referenced this issue Jan 8, 2021
Inspired by fork-ts-checker-webpack-plugin-limiter plugin - thanks @vicaryCloses: #441
piotr-oles added a commit that referenced this issue Jan 8, 2021
Inspired by fork-ts-checker-webpack-plugin-limiter plugin - thanks @vicaryCloses: #441
piotr-oles added a commit that referenced this issue Jan 10, 2021
Inspired by fork-ts-checker-webpack-plugin-limiter plugin - thanks @vicaryCloses: #441
@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment