-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example tasks.json
to README?
#269
Comments
I don't use these myself but you're not the first person to raise it. So I think we should add it.
I don't have strong feelings either way. Totally don't mind. @piotr-oles any views? |
Would be great to split |
@phryneas |
As I said in #404, I'll start dogfooding this soon. |
Here is a the {
"version": "2.0.0",
"tasks": [
{
"type": "npm",
"script": "build",
"group": "build",
"problemMatcher": ["$ts-checker5-webpack", "$ts-checker5-eslint-webpack"]
},
{
"type": "npm",
"script": "lint",
"group": "build",
"problemMatcher": ["$eslint-stylish"]
},
{
"type": "npm",
"script": "watch",
"group": {
"kind": "build",
"isDefault": true
},
"isBackground": true,
"problemMatcher": ["$ts-checker5-webpack-watch", "$ts-checker5-eslint-webpack-watch"]
}
]
} Which uses the problem matchers from my TypeScript + Webpack Problem Matchers extension |
@phryneas FYI, you can use the |
I have only just realised that gitlens uses |
🎉 This issue has been resolved in version 5.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 5.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is just something I was missing and that kept me personally from using fork-ts-checker-webpack-plugin in a few projects: integration with with the "Problems" tab in vscode.
But as I'm starting to dogfood now, too, I did a bit of googling and found https://code.visualstudio.com/docs/editor/tasks#_defining-a-multiline-problem-matcher which describes the process of defining
yarn watch
as a vscode task with a custom problem matcher.That left me with the following configuration:
.vscode/tasks.json
Which raises the question: do we want to add that to the README? While it might be very useful for many people, the README is also getting very long and this is very tool-specific information.
As an alternative: what do you think about splitting some parts of the README out into additional markdown files and link those from a FAQ section in the README?
CODE_OF_CONDUCT.md and CONTRIBUTING.md are essentially first steps into that direction.
The text was updated successfully, but these errors were encountered: