fix: use 'afterCompile' hook to fix regression described in #57

TypeStrong · Apr 18, 2020 · f88e381 · f88e381
1 parent 9439a09
commit f88e381
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/ForkTsCheckerWebpackPlugin.ts b/src/ForkTsCheckerWebpackPlugin.ts
@@ -6,17 +6,14 @@ import { createForkTsCheckerWebpackPluginConfiguration } from './ForkTsCheckerWe
 import { createForkTsCheckerWebpackPluginState } from './ForkTsCheckerWebpackPluginState';
 import { composeReporterRpcClients, createAggregatedReporter, ReporterRpcClient } from './reporter';
 import { assertTypeScriptSupport } from './typescript-reporter/assertTypeScriptSupport';
-import {
-  createTypeScriptReporterRpcClient,
-  createTypeScriptReporterSameProcessRpcClient,
-} from './typescript-reporter/reporter/TypeScriptReporterRpcClient';
+import { createTypeScriptReporterRpcClient } from './typescript-reporter/reporter/TypeScriptReporterRpcClient';
 import { assertEsLintSupport } from './eslint-reporter/assertEsLintSupport';
 import { createEsLintReporterRpcClient } from './eslint-reporter/reporter/EsLintReporterRpcClient';
 import { tapDoneToAsyncGetIssues } from './hooks/tapDoneToAsyncGetIssues';
 import { tapInvalidToUpdateState } from './hooks/tapInvalidToUpdateState';
 import { tapStartToConnectAndRunReporter } from './hooks/tapStartToConnectAndRunReporter';
 import { tapStopToDisconnectReporter } from './hooks/tapStopToDisconnectReporter';
-import { tapEmitToGetIssues } from './hooks/tapEmitToGetIssues';
+import { tapAfterCompileToGetIssues } from './hooks/tapAfterCompileToGetIssues';
 import { getForkTsCheckerWebpackPluginHooks } from './hooks/pluginHooks';
 
 class ForkTsCheckerWebpackPlugin implements webpack.Plugin {
@@ -52,7 +49,7 @@ class ForkTsCheckerWebpackPlugin implements webpack.Plugin {
       if (configuration.async) {
         tapDoneToAsyncGetIssues(compiler, configuration, state);
       } else {
-        tapEmitToGetIssues(compiler, configuration, state);
+        tapAfterCompileToGetIssues(compiler, configuration, state);
       }
     } else {
       configuration.logger.infrastructure.error(

diff --git a/src/hooks/tapEmitToGetIssues.ts → src/hooks/tapAfterCompileToGetIssues.ts b/src/hooks/tapEmitToGetIssues.ts → src/hooks/tapAfterCompileToGetIssues.ts
@@ -8,14 +8,14 @@ import { Tap } from 'tapable';
 import { getReportProgress } from './getReportProgress';
 import { Issue } from '../issue';
 
-function tapEmitToGetIssues(
+function tapAfterCompileToGetIssues(
   compiler: webpack.Compiler,
   configuration: ForkTsCheckerWebpackPluginConfiguration,
   state: ForkTsCheckerWebpackPluginState
 ) {
   const hooks = getForkTsCheckerWebpackPluginHooks(compiler);
 
-  compiler.hooks.emit.tapPromise(
+  compiler.hooks.afterCompile.tapPromise(
     {
       name: 'ForkTsCheckerWebpackPlugin',
       context: true,
@@ -66,4 +66,4 @@ function tapEmitToGetIssues(
   );
 }
 
-export { tapEmitToGetIssues };
+export { tapAfterCompileToGetIssues };